From: Johannes Berg <johannes@sipsolutions.net>
To: Ben Greear <greearb@candelatech.com>
Cc: linux-wireless@vger.kernel.org,
"John W. Linville" <linville@tuxdriver.com>
Subject: Re: [wireless] wireless: Keep phy name consistent across module reloads.
Date: Sat, 25 Sep 2010 00:25:44 +0200 [thread overview]
Message-ID: <1285367144.11036.11.camel@jlt3.sipsolutions.net> (raw)
In-Reply-To: <4C9D2487.5040202@candelatech.com>
On Fri, 2010-09-24 at 15:21 -0700, Ben Greear wrote:
> Here's a patch for consideration. It's on top of my other patch,
> but I can re-do it against a tree with that reverted if you prefer.
You also want to remove the restriction on renaming to phy%d now.
> + if (unlikely(!wiphy_idx_valid(rdev->wiphy_idx)))
> + goto too_many_devs;
> +
> /* 64k wiphy devices is enough for anyone! */
> for (i = 0; i < 0xFFFF; i++) {
why limit yourself to this? You're guaranteed to find a free index if
you don't, so error handling could be easier?
johannes
next prev parent reply other threads:[~2010-09-24 22:25 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-21 23:57 [wireless] wireless: Keep phy name consistent across module reloads greearb
2010-09-24 21:02 ` Johannes Berg
2010-09-24 21:10 ` Ben Greear
2010-09-24 21:18 ` Johannes Berg
2010-09-24 21:25 ` Ben Greear
2010-09-24 21:31 ` Johannes Berg
2010-09-24 21:33 ` Ben Greear
2010-09-24 22:21 ` Ben Greear
2010-09-24 22:25 ` Johannes Berg [this message]
2010-09-24 22:37 ` Ben Greear
2010-09-27 20:41 ` wireless-next-2.6 rebased -- " John W. Linville
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1285367144.11036.11.camel@jlt3.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=greearb@candelatech.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).