From: Luciano Coelho <luciano.coelho@nokia.com>
To: ext Johannes Berg <johannes@sipsolutions.net>
Cc: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
"Oikarinen Juuso (Nokia-MS/Tampere)" <juuso.oikarinen@nokia.com>
Subject: Re: [PATCH 07/25] wl1271: Change supported channel order for a more optimal scan
Date: Mon, 27 Sep 2010 13:50:31 +0300 [thread overview]
Message-ID: <1285584631.5768.73.camel@chilepepper> (raw)
In-Reply-To: <1285577334.4043.1.camel@jlt3.sipsolutions.net>
On Mon, 2010-09-27 at 10:48 +0200, ext Johannes Berg wrote:
> On Mon, 2010-09-27 at 11:37 +0300, Luciano Coelho wrote:
> > From: Juuso Oikarinen <juuso.oikarinen@nokia.com>
> >
> > The mac80211 inserts channels into a scan request in the same order the driver
> > registers them. Use this fact to optimize scan by ordering the channels so
> > that adjacent channels don't get scanned consecutively.
>
> Cute, but not really ...
>
> First of all, iw will also report channels in this order, and that's
> just weird.
>
> Secondly, if you pass any channels to scan manually (say with iw), this
> assertion is no longer true -- cfg80211 will actually _sort_ the
> channels in that case to make sure there are no duplicates.
>
> So you really shouldn't be doing this.
Indeed, thanks for pointing out.
This was a shortcut that seemed so easy to follow that we couldn't
resist.
I think we can release this patch as is, because it already helps in
some cases. And we'll come with a proper and generic solution in
mac80211/cfg80211 soon.
--
Cheers,
Luca.
next prev parent reply other threads:[~2010-09-27 10:50 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-27 8:37 [PATCH 00/25] wl1271: pending patches Luciano Coelho
2010-09-27 8:37 ` [PATCH 01/25] wl1271: remove deprecated ACX definition Luciano Coelho
2010-09-27 8:37 ` [PATCH 02/25] wl1271: Implement CMD_SET_STA_STATE to indicate connection completion to FW Luciano Coelho
2010-09-27 8:37 ` [PATCH 03/25] wl1271: Add trigger to net_device oper_state to change BT coex priority Luciano Coelho
2010-09-27 8:37 ` [PATCH 04/25] wl1271: Fix scan race condition Luciano Coelho
2010-09-27 8:37 ` [PATCH 05/25] wl1271: remove useless 11a check when scanning Luciano Coelho
2010-09-27 8:37 ` [PATCH 06/25] wl1271: fix forced passive scan Luciano Coelho
2010-09-27 8:37 ` [PATCH 07/25] wl1271: Change supported channel order for a more optimal scan Luciano Coelho
2010-09-27 8:48 ` Johannes Berg
2010-09-27 10:50 ` Luciano Coelho [this message]
2010-09-27 8:37 ` [PATCH 08/25] wl1271: Remove outdated FIXME's Luciano Coelho
2010-09-27 8:37 ` [PATCH 09/25] wl1271: Move setting of wake-up conditions to ps.c from cmd.c Luciano Coelho
2010-09-27 8:37 ` [PATCH 10/25] wl1271: Remove acx_fw_version function Luciano Coelho
2010-09-27 8:37 ` [PATCH 11/25] wl1271: Release interrupt *after* releasing the driver context Luciano Coelho
2010-09-27 8:37 ` [PATCH 12/25] wl1271: Remove function cmd_read_memory Luciano Coelho
2010-09-27 8:37 ` [PATCH 13/25] wl1271: Enable/disable 11a support based on INI configuration Luciano Coelho
2010-10-06 5:26 ` Gabay, Benzy
2010-10-06 5:36 ` Juuso Oikarinen
2010-10-06 6:19 ` Gabay, Benzy
2010-09-27 8:37 ` [PATCH 14/25] wl1271: Reduce rate used for last PSM entry attempt Luciano Coelho
2010-09-27 8:37 ` [PATCH 15/25] wl1271: Enable 11a support always, prevent scanning for unsupporting chips Luciano Coelho
2010-09-27 8:37 ` [PATCH 16/25] wl1271: Add support for hardware GEM cipher Luciano Coelho
2010-09-27 9:12 ` Johannes Berg
2010-09-27 9:46 ` Juuso Oikarinen
2010-09-27 9:49 ` Johannes Berg
2010-09-27 9:58 ` Juuso Oikarinen
2010-09-27 10:01 ` Luciano Coelho
2010-09-27 10:42 ` [PATCHv2] " juuso.oikarinen
2010-09-27 8:37 ` [PATCH 17/25] wl1271: Fix tid-configuration of TX frames Luciano Coelho
2010-09-27 8:51 ` Johannes Berg
2010-09-27 8:57 ` Juuso Oikarinen
2010-09-27 8:37 ` [PATCH 18/25] wl1271: Fix AC/TID default configuration Luciano Coelho
2010-09-27 8:37 ` [PATCH 19/25] wl1271: Move scan complete invocation into work function Luciano Coelho
2010-09-27 8:37 ` [PATCH 20/25] wl1271: Fix work cancelling when shutting down the driver Luciano Coelho
2010-09-27 8:37 ` [PATCH 21/25] wl1271: Separate interface removal to another function Luciano Coelho
2010-09-27 8:37 ` [PATCH 22/25] wl1271: Add hardware recovery mechanism Luciano Coelho
2010-09-27 8:37 ` [PATCH 23/25] wl1271: Add handling for failing hardware scan command Luciano Coelho
2010-09-27 8:37 ` [PATCH 24/25] wl1271: Optimize scan duration Luciano Coelho
2010-10-05 5:30 ` Gabay, Benzy
2010-10-05 5:40 ` Juuso Oikarinen
2010-10-05 15:42 ` Gabay, Benzy
2010-10-06 4:59 ` Juuso Oikarinen
2010-10-06 5:21 ` Gabay, Benzy
2010-10-06 5:26 ` Juuso Oikarinen
2010-10-06 5:50 ` Gabay, Benzy
2010-09-27 8:37 ` [PATCH 25/25] wl1271: Increase connection reliability Luciano Coelho
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1285584631.5768.73.camel@chilepepper \
--to=luciano.coelho@nokia.com \
--cc=johannes@sipsolutions.net \
--cc=juuso.oikarinen@nokia.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).