linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: Christian Lamparter <chunkeey@googlemail.com>
Cc: linux-wireless@vger.kernel.org,
	"John W. Linville" <linville@tuxdriver.com>
Subject: Re: [PATCH] carl9170: fix hung workqueue
Date: Tue, 28 Sep 2010 09:25:47 +0200	[thread overview]
Message-ID: <1285658747.3885.4.camel@jlt3.sipsolutions.net> (raw)
In-Reply-To: <201009272303.01535.chunkeey@googlemail.com>

On Mon, 2010-09-27 at 23:03 +0200, Christian Lamparter wrote:
> The patch "mac80211: wait for scan work complete before
> restarting hw", broke carl9170's restart path.
> 
> Previously it was possible to call ieee80211_restart_hw
> from mac80211's internal workqueue. Now though it hangs
> because of the flush_workqueue in the procedure.

I thought I asked somebody to move that. It's expected that you are
allowed to call it -- the flush and scan cancel code there needs to be
moved into the _work_, out of the restart_hw() function.

johannes


  reply	other threads:[~2010-09-28  7:25 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-09-27 21:03 [PATCH] carl9170: fix hung workqueue Christian Lamparter
2010-09-28  7:25 ` Johannes Berg [this message]
2010-10-01 12:51   ` Christian Lamparter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1285658747.3885.4.camel@jlt3.sipsolutions.net \
    --to=johannes@sipsolutions.net \
    --cc=chunkeey@googlemail.com \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).