From: Luciano Coelho <luciano.coelho@nokia.com>
To: ext Shahar Levi <shahar_levi@ti.com>
Cc: David Woodhouse <dwmw2@infradead.org>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH v2] linux-firmware: wl12xx-Add Firmware and NVS files to support Texas Instruments WLAN driver
Date: Tue, 28 Sep 2010 17:33:48 +0300 [thread overview]
Message-ID: <1285684428.4728.1.camel@powerslave> (raw)
In-Reply-To: <1285682308-20189-1-git-send-email-shahar_levi@ti.com>
On Tue, 2010-09-28 at 15:58 +0200, ext Shahar Levi wrote:
> FW & NVS Support wl127x wireless LAN driver (wl1271 & wl1273).
> In order to use those files copy them to target FS at /lib/firmware/.
>
> Changes from v1:
> - Update the wl1271-nvs.bin that support a band to the correct size (912B)
It doesn't matter much, in my opinion, but this "Changes from v1"
shouldn't be in the actual commit log. If you put this kind of comment
after the --- (below marked with <HERE>), it is informative for whoever
is reading your patch email, but it won't go into git history (where
this information is a useless, because v1 is not there).
> Signed-off-by: Shahar Levi <shahar_levi@ti.com>
> ---
I'll test this patch soon and see if the NVS works now.
--
Cheers,
Luca.
next prev parent reply other threads:[~2010-09-28 14:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-28 13:58 [PATCH v2] linux-firmware: wl12xx-Add Firmware and NVS files to support Texas Instruments WLAN driver Shahar Levi
2010-09-28 14:33 ` Luciano Coelho [this message]
2010-10-01 14:41 ` Luciano Coelho
2010-09-29 3:11 ` David Woodhouse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1285684428.4728.1.camel@powerslave \
--to=luciano.coelho@nokia.com \
--cc=dwmw2@infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=shahar_levi@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).