linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: greearb@candelatech.com
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH v3] mac80211:  Allow scanning single channel if other VIF is associated.
Date: Wed, 29 Sep 2010 09:02:13 +0200	[thread overview]
Message-ID: <1285743733.3756.3.camel@jlt3.sipsolutions.net> (raw)
In-Reply-To: <1285708650-21858-1-git-send-email-greearb@candelatech.com>

On Tue, 2010-09-28 at 14:17 -0700, greearb@candelatech.com wrote:
> From: Ben Greear <greearb@candelatech.com>
> 
> This patch aims to decrease channel switching when there is at least one
> interface associated.  This should help multiple station interfaces co-exist
> on the same hardware, especially in WPA mode.
> 
> Signed-off-by: Ben Greear <greearb@candelatech.com>
> ---
> 
> v2 -> v3:  Just check can_scan_one flag and if set and there is
>    a vif associated, select the active channel as scan-channel and
>    let core scanning logic function as designed.
> 
>    This gets much of the really ugly logic changes out of the
>    scanning core, and any optimizations to this should help
>    general purpose scanning on a single channel as well.

> --- a/include/linux/nl80211.h
> +++ b/include/linux/nl80211.h
> @@ -965,6 +965,8 @@ enum nl80211_attrs {
>  	NL80211_ATTR_CONTROL_PORT_ETHERTYPE,
>  	NL80211_ATTR_CONTROL_PORT_NO_ENCRYPT,
>  
> +	NL80211_ATTR_SCAN_ONE_IF_ASSOC,
> +

Still NACK, I don't see the need for new API for this odd case.

Please don't resubmit similar patches to this, I don't want to nack them
all the time.

johannes


  reply	other threads:[~2010-09-29  7:02 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-09-28 21:17 [PATCH v3] mac80211: Allow scanning single channel if other VIF is associated greearb
2010-09-29  7:02 ` Johannes Berg [this message]
2010-09-29 15:30   ` Ben Greear
2010-09-29 16:48     ` Johannes Berg
2010-09-29 16:58       ` Ben Greear
2010-09-29 17:03         ` Johannes Berg
2010-09-29 17:44       ` Ben Greear
2010-09-29 18:05         ` Johannes Berg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1285743733.3756.3.camel@jlt3.sipsolutions.net \
    --to=johannes@sipsolutions.net \
    --cc=greearb@candelatech.com \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).