From: Johannes Berg <johannes@sipsolutions.net>
To: "Luis R. Rodriguez" <lrodriguez@atheros.com>
Cc: Vasanthakumar Thiagarajan <vasanth@atheros.com>,
Vasanth Thiagarajan <Vasanth.Thiagarajan@atheros.com>,
Jouni Malinen <j@w1.fi>,
"linville@tuxdriver.com" <linville@tuxdriver.com>,
"stable@kernel.org" <stable@kernel.org>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
Paul Stewart <pstew@google.com>,
Amod Bodas <Amod.Bodas@atheros.com>
Subject: Re: [PATCH] mac80211: fix rate_control_send_low warnings for delbas
Date: Wed, 29 Sep 2010 19:24:03 +0200 [thread overview]
Message-ID: <1285781043.3756.28.camel@jlt3.sipsolutions.net> (raw)
In-Reply-To: <AANLkTikUAchrjeMraauLaUggtq7bYZoki=kz2o8XQ2yh@mail.gmail.com>
On Wed, 2010-09-29 at 10:16 -0700, Luis R. Rodriguez wrote:
> > 2. NL80211_CMD_ASSOCIATE to newly authenticated AP from user space
> >
> > - Clean up any existing BA session with an AP, if any.
> > Here the assumption is, ieee80211_work_work() has already
> > configured the device back to it's operating channel (the
> > old one) after the authentication is complete with the new
> > AP. This should have happened part of 1.
> > - Start the association process with the new AP.
>
> No see, I believe we actually get the association response and *then*
> we teardown the BA agreements. Let me review this some more today.
No, Vasanth's right, but there's a race:
* we go off-channel
* we send auth
* we get auth
* we notify wpa_s
* wpa_s asks for assoc | these aren't ordered
* we disassoc | quite right but it's
* we return from off-channel | hard to avoid ...
* we assoc to new AP
johannes
next prev parent reply other threads:[~2010-09-29 17:24 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-28 22:29 [PATCH] mac80211: fix rate_control_send_low warnings for delbas Luis R. Rodriguez
2010-09-28 23:02 ` Jouni Malinen
2010-09-28 23:58 ` Luis R. Rodriguez
2010-09-29 5:20 ` Vasanthakumar Thiagarajan
2010-09-29 7:24 ` Luis R. Rodriguez
2010-09-29 8:56 ` Vasanthakumar Thiagarajan
2010-09-29 17:16 ` Luis R. Rodriguez
2010-09-29 17:24 ` Johannes Berg [this message]
2010-09-29 8:18 ` Johannes Berg
2010-09-29 17:10 ` Luis R. Rodriguez
2010-09-29 17:25 ` Johannes Berg
2010-09-30 17:53 ` Luis R. Rodriguez
2010-10-01 20:07 ` Luis R. Rodriguez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1285781043.3756.28.camel@jlt3.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=Amod.Bodas@atheros.com \
--cc=Vasanth.Thiagarajan@atheros.com \
--cc=j@w1.fi \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=lrodriguez@atheros.com \
--cc=pstew@google.com \
--cc=stable@kernel.org \
--cc=vasanth@atheros.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).