From: greearb@candelatech.com
To: linux-wireless@vger.kernel.org
Cc: Ben Greear <greearb@candelatech.com>
Subject: [PATCH 2/2] mac80211: Don't go off-channel in work_work unless needed.
Date: Wed, 29 Sep 2010 11:03:03 -0700 [thread overview]
Message-ID: <1285783383-20822-2-git-send-email-greearb@candelatech.com> (raw)
In-Reply-To: <1285783383-20822-1-git-send-email-greearb@candelatech.com>
From: Ben Greear <greearb@candelatech.com>
If the work to be done is on the current active channel, then
do not call the offchannel and return-to-channel logic.
Signed-off-by: Ben Greear <greearb@candelatech.com>
---
:100644 100644 ae344d1... 1f2673d... M net/mac80211/work.c
net/mac80211/work.c | 28 ++++++++++++++++++++--------
1 files changed, 20 insertions(+), 8 deletions(-)
diff --git a/net/mac80211/work.c b/net/mac80211/work.c
index ae344d1..1f2673d 100644
--- a/net/mac80211/work.c
+++ b/net/mac80211/work.c
@@ -873,6 +873,7 @@ static void ieee80211_work_work(struct work_struct *work)
LIST_HEAD(free_work);
enum work_action rma;
bool remain_off_channel = false;
+ bool went_off_channel = false;
if (local->scanning)
return;
@@ -910,12 +911,21 @@ static void ieee80211_work_work(struct work_struct *work)
* happen to be on the same channel as
* the requested channel
*/
- ieee80211_offchannel_stop_beaconing(local);
- ieee80211_offchannel_stop_station(local);
-
- local->tmp_channel = wk->chan;
- local->tmp_channel_type = wk->chan_type;
- ieee80211_hw_config(local, 0);
+ WARN_ON(local->scan_channel != NULL);
+ if (wk->chan != local->oper_channel ||
+ wk->chan_type != local->_oper_channel_type) {
+ /* Only change channels if we need to */
+ ieee80211_offchannel_stop_beaconing(local);
+ ieee80211_offchannel_stop_station(local);
+
+ local->tmp_channel = wk->chan;
+ local->tmp_channel_type = wk->chan_type;
+ ieee80211_hw_config(local, 0);
+ went_off_channel = true;
+ } else {
+ local->tmp_channel = wk->chan;
+ local->tmp_channel_type = wk->chan_type;
+ }
started = true;
wk->timeout = jiffies;
}
@@ -989,8 +999,10 @@ static void ieee80211_work_work(struct work_struct *work)
if (!remain_off_channel && local->tmp_channel) {
local->tmp_channel = NULL;
- ieee80211_hw_config(local, 0);
- ieee80211_offchannel_return(local, true);
+ if (went_off_channel) {
+ ieee80211_hw_config(local, 0);
+ ieee80211_offchannel_return(local, true);
+ }
/* give connection some time to breathe */
run_again(local, jiffies + HZ/2);
}
--
1.7.2.2
next prev parent reply other threads:[~2010-09-29 18:03 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-29 18:03 [PATCH 1/2] mac80211: Make no-probe-response kernel messages more useful greearb
2010-09-29 18:03 ` greearb [this message]
2010-09-29 18:06 ` [PATCH 2/2] mac80211: Don't go off-channel in work_work unless needed Johannes Berg
2010-09-29 18:11 ` Ben Greear
2010-09-29 18:14 ` Johannes Berg
2010-09-29 23:03 ` [PATCH 1/2] mac80211: Make no-probe-response kernel messages more useful Julian Calaby
2010-09-29 23:19 ` Joe Perches
2010-09-30 7:49 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1285783383-20822-2-git-send-email-greearb@candelatech.com \
--to=greearb@candelatech.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).