From: Johannes Berg <johannes@sipsolutions.net>
To: Ben Greear <greearb@candelatech.com>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH v3] mac80211: Allow scanning single channel if other VIF is associated.
Date: Wed, 29 Sep 2010 20:05:51 +0200 [thread overview]
Message-ID: <1285783551.3756.30.camel@jlt3.sipsolutions.net> (raw)
In-Reply-To: <4CA37B16.2040002@candelatech.com>
On Wed, 2010-09-29 at 10:44 -0700, Ben Greear wrote:
> > Also, I believe it needs matching code to not do all the return stuff
> > since we never left the channel, and I think it still needs to set
> > tmp_channel so that nothing will switch away underneath or so... not
> > quite sure.
>
> Doesn't the remain_off_channel logic later in that method
> take care of not calling the return to channel logic?
> (Assuming I set the tmp_channel and tmp_channel_type as you suggest)?
If you set it, I believe it'll actually do the return work, and if you
leave it NULL it won't ... maybe just leaving it NULL is fine, as long
as we hope it won't switch away underneath, it probably shouldn't.
johannes
prev parent reply other threads:[~2010-09-29 18:05 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-28 21:17 [PATCH v3] mac80211: Allow scanning single channel if other VIF is associated greearb
2010-09-29 7:02 ` Johannes Berg
2010-09-29 15:30 ` Ben Greear
2010-09-29 16:48 ` Johannes Berg
2010-09-29 16:58 ` Ben Greear
2010-09-29 17:03 ` Johannes Berg
2010-09-29 17:44 ` Ben Greear
2010-09-29 18:05 ` Johannes Berg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1285783551.3756.30.camel@jlt3.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=greearb@candelatech.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).