From: Luciano Coelho <luciano.coelho@nokia.com>
To: ext Ido Yariv <ido@wizery.com>
Cc: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
"Oikarinen Juuso (Nokia-MS/Tampere)" <juuso.oikarinen@nokia.com>,
Ohad Ben-Cohen <ohad@wizery.com>
Subject: Re: [PATCH v3 0/3] wl1271: Packet aggregation optimizations
Date: Thu, 30 Sep 2010 22:24:58 +0300 [thread overview]
Message-ID: <1285874698.1578.9.camel@powerslave> (raw)
In-Reply-To: <1285853308-24290-1-git-send-email-ido@wizery.com>
On Thu, 2010-09-30 at 15:28 +0200, ext Ido Yariv wrote:
> The WL1271 HW supports sending and receiving multiple packets within
> a single transaction. This can substantially reduce CPU usage and
> increase network throughput.
>
> The following patches add support for RX and TX packet aggregation.
> An opportunistic approach was taken - all packets that are currently
> available for sending/receiving are aggregated and transferred
> in a single transaction.
>
> On SPI platforms, tests done by Juuso Oikarinen have shown a 20% improvement
> in CPU usage.
> On SDIO platforms, some tests have shown an improvement of over 30% in CPU
> usage.
>
> Changes since v2:
> Fix debug output in the SPI callbacks.
>
> Changes since v1:
> The SPI callbacks do not handle large transfers well. The first patch fixes
> this by fragmenting large transfers into smaller ones.
>
> Thanks Juuso Oikarinen for reporting the SPI issue and helping with testing
> and benchmarking these optimizations.
This looks very good. Thanks for your work and thanks Juuso for the
tests and verification.
I'll apply this as soon as John pulls our wl12xx tree, so we can keep it
linear.
--
Cheers,
Luca.
next prev parent reply other threads:[~2010-09-30 19:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-30 13:28 [PATCH v3 0/3] wl1271: Packet aggregation optimizations Ido Yariv
2010-09-30 13:28 ` [PATCH v3 1/3] wl1271: Handle large SPI transfers Ido Yariv
2010-09-30 13:28 ` [PATCH v3 2/3] wl1271: Support firmware RX packet aggregation Ido Yariv
2010-09-30 13:28 ` [PATCH v3 3/3] wl1271: Support firmware TX " Ido Yariv
2010-09-30 19:24 ` Luciano Coelho [this message]
2010-10-05 11:18 ` [PATCH v3 0/3] wl1271: Packet aggregation optimizations Luciano Coelho
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1285874698.1578.9.camel@powerslave \
--to=luciano.coelho@nokia.com \
--cc=ido@wizery.com \
--cc=juuso.oikarinen@nokia.com \
--cc=linux-wireless@vger.kernel.org \
--cc=ohad@wizery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).