From: Johannes Berg <johannes@sipsolutions.net>
To: Christian Lamparter <chunkeey@googlemail.com>,
linux-wireless@vger.kernel.org
Cc: "John W. Linville" <linville@tuxdriver.com>
Subject: Re: [PATCH] mac80211: fix rx monitor filter refcounters
Date: Sat, 02 Oct 2010 10:46:27 +0200 [thread overview]
Message-ID: <1286009187.1646.2.camel@Nokia-N900-51-1> (raw)
In-Reply-To: <201010012353.21053.chunkeey@googlemail.com>
> > I'm fine with not allowing the cook flag to change,
> > seems like a pretty special case anyway. Or, we can
> > allow it to change, but only while the interface is
> > down, right?
> jup, works:
>
> command failed: Function not implemented (-38), or should
> we use a different error code like -EBUSY/-EOPNOTSUPP?
I think typically I'd use ebusy, and I think it'd be more descriptive here?
> + if (test_bit(SDATA_STATE_RUNNING, &sdata->state)) {
There's an inline for this, I think?
> static inline bool ieee80211_sdata_running(struct ieee80211_sub_if_data
heh, by accident it's even in your patch :)
ACK with those two changes.
Johannes
next prev parent reply other threads:[~2010-10-02 8:45 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-28 16:36 [RFC] mac80211: fix rx monitor filter refcounters Christian Lamparter
2010-09-29 7:10 ` Johannes Berg
2010-09-29 19:57 ` [RFC v2] " Christian Lamparter
2010-09-29 20:00 ` Johannes Berg
2010-10-01 21:53 ` [PATCH] " Christian Lamparter
2010-10-02 8:46 ` Johannes Berg [this message]
2010-10-02 11:17 ` [PATCH v2] " Christian Lamparter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1286009187.1646.2.camel@Nokia-N900-51-1 \
--to=johannes@sipsolutions.net \
--cc=chunkeey@googlemail.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox