From: Luciano Coelho <luciano.coelho@nokia.com>
To: "juuso.oikarinen@nokia.com" <juuso.oikarinen@nokia.com>
Cc: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH 2/2] wl1271: Move work-init calls to hw allocation
Date: Mon, 04 Oct 2010 13:45:51 +0300 [thread overview]
Message-ID: <1286189151.27112.12.camel@chilepepper> (raw)
In-Reply-To: <1285843408-6726-2-git-send-email-juuso.oikarinen@nokia.com>
On Thu, 2010-09-30 at 12:43 +0200, juuso.oikarinen@nokia.com wrote:
> From: Juuso Oikarinen <juuso.oikarinen@nokia.com>
>
> Due to legacy reason, dating back to when the wl1251 and wl1271 still were
> a unified driver, some work-structures are initialized on hardware startup.
>
> The hardware recovery code creates a scenario in which it is possible for a
> workstruct to be re-initialized while the work-function itself is running,
> which causes a kernel WARNing and a subsequent reboot.
>
> To remedy this, move the work initialization calls to the hw allocation,
> which is the logically correct place for them anyway.
>
> Signed-off-by: Juuso Oikarinen <juuso.oikarinen@nokia.com>
> ---
Reviewed-by: Luciano Coelho <luciano.coelho@nokia.com>
I'll apply this soon.
--
Cheers,
Luca.
next prev parent reply other threads:[~2010-10-04 10:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-30 10:43 [PATCH 1/2] wl1271: Indicate disconnection on hardware failure juuso.oikarinen
2010-09-30 10:43 ` [PATCH 2/2] wl1271: Move work-init calls to hw allocation juuso.oikarinen
2010-10-04 10:45 ` Luciano Coelho [this message]
[not found] ` <1285846632.11177.163.camel@wimaxnb.nmp.nokia.com>
2010-09-30 11:45 ` Tuomas Katila
2010-10-04 10:45 ` [PATCH 1/2] wl1271: Indicate disconnection on hardware failure Luciano Coelho
2010-10-05 11:18 ` Luciano Coelho
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1286189151.27112.12.camel@chilepepper \
--to=luciano.coelho@nokia.com \
--cc=juuso.oikarinen@nokia.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).