From: Johannes Berg <johannes@sipsolutions.net>
To: Ben Greear <greearb@candelatech.com>
Cc: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: Re: Putting APs into bridges?
Date: Mon, 04 Oct 2010 20:29:29 +0200 [thread overview]
Message-ID: <1286216969.3620.44.camel@jlt3.sipsolutions.net> (raw)
In-Reply-To: <4CAA0D5E.2090700@candelatech.com>
On Mon, 2010-10-04 at 10:22 -0700, Ben Greear wrote:
> It seems he put two VAPs into a bridge device, and got an
> assert here (nevermind the printk, I just added that to
> help debug the issue).
>
> static void __ieee80211_wake_queue(struct ieee80211_hw *hw, int queue,
> enum queue_stop_reason reason)
> {
> struct ieee80211_local *local = hw_to_local(hw);
> struct ieee80211_sub_if_data *sdata;
>
> trace_wake_queue(local, queue, reason);
>
> if (WARN_ON(queue >= hw->queues)) {
> printk(KERN_WARNING "%s: queue: %i hw->queues: %i\n",
> sdata->name, queue, hw->queues);
> return;
> }
>
>
> Before I try to reproduce this, it is valid to add APs to bridge
> devices in the first place?
Yes, it's valid, we catch the invalid cases in cfg80211.
Hitting the assert there is rather strange though.
johannes
next prev parent reply other threads:[~2010-10-04 18:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-04 17:22 Putting APs into bridges? Ben Greear
2010-10-04 18:29 ` Johannes Berg [this message]
2010-10-05 3:43 ` Bruno Randolf
2010-10-05 3:45 ` Ben Greear
2010-10-05 3:56 ` Bruno Randolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1286216969.3620.44.camel@jlt3.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=greearb@candelatech.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).