From: Johannes Berg <johannes@sipsolutions.net>
To: Ben Greear <greearb@candelatech.com>
Cc: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: Re: more crashing goodness with ath9k
Date: Tue, 05 Oct 2010 20:52:48 +0200 [thread overview]
Message-ID: <1286304768.3641.26.camel@jlt3.sipsolutions.net> (raw)
In-Reply-To: <4CAB6F96.6090701@candelatech.com>
On Tue, 2010-10-05 at 11:33 -0700, Ben Greear wrote:
> This is with 8 STA configured with WPA.
>
> Memory poisoning, etc is enabled.
>
>
> Reading symbols from /home/greearb/kernel/2.6/wireless-testing-dbg.p4s/net/mac80211/mac80211.ko...done.
> (gdb) l *(sta_addba_resp_timer_expired+0x7c)
> 0x5b38 is in sta_addba_resp_timer_expired (/home/greearb/git/linux.wireless-testing/arch/x86/include/asm/bitops.h:312).
This ought to help, but I'm not sure the locking etc. is 100% correct
yet.
johannes
---
net/mac80211/agg-tx.c | 3 +++
1 file changed, 3 insertions(+)
--- wireless-testing.orig/net/mac80211/agg-tx.c 2010-10-05 20:40:02.000000000 +0200
+++ wireless-testing/net/mac80211/agg-tx.c 2010-10-05 20:51:59.000000000 +0200
@@ -163,6 +163,7 @@ int ___ieee80211_stop_tx_ba_session(stru
/* not even started yet! */
rcu_assign_pointer(sta->ampdu_mlme.tid_tx[tid], NULL);
spin_unlock_bh(&sta->lock);
+ del_timer_sync(&tid_tx->addba_resp_timer);
call_rcu(&tid_tx->rcu_head, kfree_tid_tx);
return 0;
}
@@ -176,6 +177,8 @@ int ___ieee80211_stop_tx_ba_session(stru
set_bit(HT_AGG_STATE_STOPPING, &tid_tx->state);
+ del_timer_sync(&tid_tx->addba_resp_timer);
+
/*
* After this packets are no longer handed right through
* to the driver but are put onto tid_tx->pending instead,
next prev parent reply other threads:[~2010-10-05 18:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-05 18:33 more crashing goodness with ath9k Ben Greear
2010-10-05 18:52 ` Johannes Berg [this message]
2010-10-05 19:05 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1286304768.3641.26.camel@jlt3.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=greearb@candelatech.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).