Re: [PATCH v3] mac80211: Add WME information element for IBSS

[Johannes Berg <johannes@sipsolutions.net>]

On Tue, 2010-10-05 at 10:24 +0900, Bruno Randolf wrote:
> On Mon October 4 2010 20:21:40 Johannes Berg wrote:
> > On Mon, 2010-10-04 at 11:17 +0900, Bruno Randolf wrote:
> > > Enable WME QoS in IBSS mode by adding a WME information element to
> > > beacons and probe respones and by checking for it and marking stations
> > > as WME capable if it is present.
> > > 
> > > Signed-off-by: Bruno Randolf <br1@einfach.org>
> > > 
> > > ---
> > > v3: use GFP_ATOMIC and re-organize nesting of "if" statements. allthough
> > > in practice we would probaby always have the rates element i think it's
> > > more correct to code it like this.
> > 
> > You're probably right, but shouldn't that be a separate patch? It
> > doesn't relate to WME at all, afaict.
> 
> it does. before we only looked at elems->supp_rates, so it was o.k. to combine 
> that check into the first if (adhoc mode && bssid matches). now we also check 
> elems->wmm_info so we should make separate cases for each. as i noted, it 
> probably does not matter much in practice, since elems->supp_rates should be 
> present in all proper beacons and probe responses.

Fair enough, looks fine to me.

johannes