From: Luciano Coelho <luciano.coelho@nokia.com>
To: ext Tony Lindgren <tony@atomide.com>,
"John W. Linville" <linville@tuxdriver.com>
Cc: Anand Gadiyar <gadiyar@ti.com>,
"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
Ohad Ben-Cohen <ohad@wizery.com>
Subject: Re: [PATCH] omap: zoom2/3: fix build caused by wl1271 support
Date: Tue, 05 Oct 2010 23:39:47 +0300 [thread overview]
Message-ID: <1286311187.2793.7.camel@powerslave> (raw)
In-Reply-To: <1286284790.15401.53.camel@chilepepper>
On Tue, 2010-10-05 at 15:19 +0200, ext Luciano Coelho wrote:
> On Tue, 2010-10-05 at 14:07 +0200, ext Luciano Coelho wrote:
> > On Tue, 2010-10-05 at 13:53 +0200, ext Luciano Coelho wrote:
> > > On Sat, 2010-10-02 at 01:10 +0200, ext Tony Lindgren wrote:
> > > > * Anand Gadiyar <gadiyar@ti.com> [101001 13:25]:
> > > > > Patch "omap: zoom: add mmc3/wl1271 device support" in the
> > > > > wireless tree still uses .wires in struct omap2_hsmmc_info.
> > > > > .wires has now been replaced with .caps in patch "omap: mmc:
> > > > > extended to pass host capabilities from board file" in the
> > > > > OMAP tree.
> > > > >
> > > > > This causes linux-next as of 20101001 build to break as
> > > > > below. Fix this.
> > > > >
> > > > > CC arch/arm/mach-omap2/board-zoom-peripherals.o
> > > > > arch/arm/mach-omap2/board-zoom-peripherals.c:217: error: unknown field 'wires' specified in initializer
> > > > > make[1]: *** [arch/arm/mach-omap2/board-zoom-peripherals.o] Error 1
> > > > > make: *** [arch/arm/mach-omap2] Error 2
> > > >
> > > > Can you guys please queue this via the wireless tree along with
> > > > the other wl1271 patches?
> > > >
> > > > Acked-by: Tony Lindgren <tony@atomide.com>
> > >
> > > I can apply this to the wl12xx tree. I just need John's confirmation.
> > >
> > > The pull request I sent to John last week is still pending. I don't
> > > know if it is possible to substitute it for a newer one with more
> > > patches (and still try to make it to 2.6.37). What do you think, John?
> >
> > Damn, for some reason I had a bug in John's email in my contact book.
> > Now sending to the correct email address.
>
> Applied to the wl12xx tree. I'll send a new replacement pull to John
> today, including this patch. Thanks.
Hmmm... We got a problem here. This patch breaks builds when we *don't*
have "omap: mmc extended to pass host capabilities from board file". We
don't have that on wireless-next yet, so builds with zoom boards
selected are broken.
Any ideas on how to solve this dilemma? I guess the proper way to handle
this would be to make the changes proposed in this patch when merging
instead of having a normal commit for it, wouldn't it?
--
Cheers,
Luca.
next prev parent reply other threads:[~2010-10-05 20:40 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-01 20:33 [PATCH] omap: zoom2/3: fix build caused by wl1271 support Anand Gadiyar
2010-10-01 23:10 ` Tony Lindgren
2010-10-05 11:53 ` Luciano Coelho
2010-10-05 12:07 ` Luciano Coelho
2010-10-05 13:19 ` Luciano Coelho
2010-10-05 20:39 ` Luciano Coelho [this message]
2010-10-06 13:52 ` John W. Linville
2010-10-06 14:01 ` Gadiyar, Anand
2010-10-06 15:27 ` Luciano Coelho
2010-10-06 15:30 ` John W. Linville
2010-10-06 15:55 ` Luciano Coelho
2010-10-06 19:34 ` Luciano Coelho
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1286311187.2793.7.camel@powerslave \
--to=luciano.coelho@nokia.com \
--cc=gadiyar@ti.com \
--cc=linux-omap@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=ohad@wizery.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).