From: Johannes Berg <johannes@sipsolutions.net>
To: Ben Greear <greearb@candelatech.com>
Cc: John Linville <linville@tuxdriver.com>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH wireless-2.6] mac80211: delete AddBA response timer
Date: Tue, 05 Oct 2010 22:41:29 +0200 [thread overview]
Message-ID: <1286311289.3641.34.camel@jlt3.sipsolutions.net> (raw)
In-Reply-To: <4CAB8C39.5090201@candelatech.com>
On Tue, 2010-10-05 at 13:36 -0700, Ben Greear wrote:
> >> I've reproduced the scenario and tested the fix.
> > This fixes the crash reported at
> > http://mid.gmane.org/4CAB6F96.6090701@candelatech.com
>
> I can no longer reproduce that problem, so it looks fixed
> to me.
Yeah .. I did actually go and reproduce the crash by strategically
adding an msleep(200) to the mac80211 code and then doing some things
from userspace :-)
> The data corruption issue still exists, however...
That looks very much like an ath9k issue, it seems like it's doing DMA
into already freed SKBs. Come to think of it, maybe that wmb() patch
might help?:
johannes
next prev parent reply other threads:[~2010-10-05 20:41 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-05 19:40 [PATCH wireless-2.6] mac80211: delete AddBA response timer Johannes Berg
2010-10-05 20:10 ` Johannes Berg
2010-10-05 20:36 ` Ben Greear
2010-10-05 20:41 ` Johannes Berg [this message]
2010-10-05 20:52 ` Ben Greear
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1286311289.3641.34.camel@jlt3.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=greearb@candelatech.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).