From: Johannes Berg <johannes@sipsolutions.net>
To: Christian Lamparter <chunkeey@googlemail.com>
Cc: linux-wireless@vger.kernel.org, linville@tuxdriver.com,
Ben Greear <greearb@candelatech.com>,
Ming Lei <tom.leiming@gmail.com>
Subject: Re: [PATCH] mac80211: hoist sta->lock from reorder release timer
Date: Wed, 06 Oct 2010 13:46:18 +0200 [thread overview]
Message-ID: <1286365578.3655.187.camel@jlt3.sipsolutions.net> (raw)
In-Reply-To: <201010061343.23463.chunkeey@googlemail.com>
On Wed, 2010-10-06 at 13:43 +0200, Christian Lamparter wrote:
> > Basically the thing is that until your patch, the data in the struct
> > didn't actually need locking because it was accessed by the RX path only
> > which is not concurrent.
> >
> I see. So basically all rx handlers are affected by these rx->sta races.
>
> John, can you please revert (or at least drop from the upcoming 2.6.37-rcX cycle):
>
> (mac80211: fix release_reorder_timeout in scan)
> mac80211: fix rcu-unsafe pointer dereference
> mac80211: AMPDU rx reorder timeout timer
> (mac80211: remove unused rate function parameter)
> mac80211: put rx handlers into separate functions
I think it's probably easier to fix than to revert now? There are only a
handful of fields, and it seemed to me that most of them can easily be
moved under the reorder lock.
johannes
next prev parent reply other threads:[~2010-10-06 11:46 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-06 10:00 [PATCH] mac80211: hoist sta->lock from reorder release timer Christian Lamparter
2010-10-06 10:10 ` Johannes Berg
2010-10-06 10:20 ` Christian Lamparter
2010-10-06 10:41 ` Johannes Berg
2010-10-06 11:43 ` Christian Lamparter
2010-10-06 11:46 ` Johannes Berg [this message]
2010-10-06 20:21 ` John W. Linville
2010-10-07 21:03 ` Johannes Berg
2010-10-08 16:42 ` Christian Lamparter
2010-10-08 16:53 ` Johannes Berg
2010-10-08 18:12 ` Christian Lamparter
2010-10-08 18:45 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1286365578.3655.187.camel@jlt3.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=chunkeey@googlemail.com \
--cc=greearb@candelatech.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=tom.leiming@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).