From: Johannes Berg <johannes@sipsolutions.net>
To: "Levi, Shahar" <shahar_levi@ti.com>
Cc: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
Luciano Coelho <luciano.coelho@nokia.com>
Subject: RE: [PATCH v2 03/03] wl1271: 11n Support, functionality and configuration ability
Date: Wed, 06 Oct 2010 21:45:30 +0200 [thread overview]
Message-ID: <1286394330.3655.429.camel@jlt3.sipsolutions.net> (raw)
In-Reply-To: <AC090B9732AB2B4DB7FF476E907FE660011378562B@dnce02.ent.ti.com>
On Wed, 2010-10-06 at 21:38 +0200, Levi, Shahar wrote:
> > > /* peek into the rates configured in the STA entry */
> > > spin_lock_irqsave(&wl->wl_lock, flags);
> > > - if (sta && sta->supp_rates[conf->channel->band] != wl->sta_rate_set) {
> > > + if (sta &&
> > > + (sta->supp_rates[conf->channel->band] !=
> > > + (wl->sta_rate_set & HW_BG_RATES_MASK))) {
> > > wl->sta_rate_set = sta->supp_rates[conf->channel->band];
> > > set_bit(WL1271_FLAG_STA_RATES_CHANGED, &wl->flags);
> > > }
> >
> > ???
> >
> > How can non-BG rates ever show up there? Is this really an 11a change?
> >
> > johannes
>
>
> Thanks for the review.
> Non BG rates set in the next if:
> + if (sta &&
> + sta->ht_cap.ht_supported &&
> + ((wl->sta_rate_set >> HW_HT_RATES_OFFSET) !=
> + sta->ht_cap.mcs.rx_mask[0])) {
> + wl->sta_rate_set |=
> + (sta->ht_cap.mcs.rx_mask[0] << HW_HT_RATES_OFFSET);
> + set_bit(WL1271_FLAG_STA_RATES_CHANGED, &wl->flags);
> sta_rate_set bits are: bits0-15 BG, bits 16-23 MCS.
> Did you meant 11n change?
Never mind, I misread the patch.
johannes
next prev parent reply other threads:[~2010-10-06 19:45 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-06 18:08 [PATCH v2 00/03] wl1271: 11n Support, add support to 80211n spec Shahar Levi
2010-10-06 18:08 ` [PATCH v2] " Shahar Levi
2010-10-06 18:08 ` [PATCH v2 01/03] wl1271: 11n Support, Add Definitions Shahar Levi
2010-10-07 18:20 ` Luciano Coelho
2010-10-08 11:44 ` Luciano Coelho
2010-10-10 10:12 ` Shahar Levi
2010-10-06 18:08 ` [PATCH v2 02/03] wl1271: 11n Support, ACX Commands Shahar Levi
2010-10-07 18:37 ` Luciano Coelho
2010-10-10 10:26 ` Shahar Levi
2010-10-06 18:08 ` [PATCH v2 03/03] wl1271: 11n Support, functionality and configuration ability Shahar Levi
2010-10-06 18:21 ` Johannes Berg
2010-10-06 19:38 ` Levi, Shahar
2010-10-06 19:45 ` Johannes Berg [this message]
2010-10-08 9:05 ` Luciano Coelho
2010-10-10 15:24 ` Shahar Levi
2010-10-11 13:55 ` Luciano Coelho
2010-10-11 14:28 ` Shahar Levi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1286394330.3655.429.camel@jlt3.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=luciano.coelho@nokia.com \
--cc=shahar_levi@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).