From: Luciano Coelho <luciano.coelho@nokia.com>
To: ext Shahar Levi <shahar_levi@ti.com>
Cc: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH v2 01/03] wl1271: 11n Support, Add Definitions
Date: Fri, 08 Oct 2010 14:44:49 +0300 [thread overview]
Message-ID: <1286538289.21349.99.camel@chilepepper> (raw)
In-Reply-To: <1286475613.1662.41.camel@powerslave>
On Thu, 2010-10-07 at 20:20 +0200, ext Luciano Coelho wrote:
> > diff --git a/drivers/net/wireless/wl12xx/wl1271_conf.h
> b/drivers/net/wireless/wl12xx/wl1271_conf.h
> > index 60c50d1..732e9aa 100644
> > --- a/drivers/net/wireless/wl12xx/wl1271_conf.h
> > +++ b/drivers/net/wireless/wl12xx/wl1271_conf.h
> > @@ -91,6 +91,10 @@ enum {
> > CONF_HW_RXTX_RATE_UNSUPPORTED = 0xff
> > };
> >
> > +#define HW_RX_HIGHEST_RATE 65
> > +#define HW_BG_RATES_MASK 0xffff
> > +#define HW_HT_RATES_OFFSET 16
>
> We preceed all the other macros with CONF_, please do the same for
> these.
Actually, we use the wl1271_conf.h file only for driver configuration
parameters. These macros should be elsewhere, such as in the wl1271.h
file. And no need to put CONF_ before them in that case.
--
Cheers,
Luca.
next prev parent reply other threads:[~2010-10-08 11:44 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-06 18:08 [PATCH v2 00/03] wl1271: 11n Support, add support to 80211n spec Shahar Levi
2010-10-06 18:08 ` [PATCH v2] " Shahar Levi
2010-10-06 18:08 ` [PATCH v2 01/03] wl1271: 11n Support, Add Definitions Shahar Levi
2010-10-07 18:20 ` Luciano Coelho
2010-10-08 11:44 ` Luciano Coelho [this message]
2010-10-10 10:12 ` Shahar Levi
2010-10-06 18:08 ` [PATCH v2 02/03] wl1271: 11n Support, ACX Commands Shahar Levi
2010-10-07 18:37 ` Luciano Coelho
2010-10-10 10:26 ` Shahar Levi
2010-10-06 18:08 ` [PATCH v2 03/03] wl1271: 11n Support, functionality and configuration ability Shahar Levi
2010-10-06 18:21 ` Johannes Berg
2010-10-06 19:38 ` Levi, Shahar
2010-10-06 19:45 ` Johannes Berg
2010-10-08 9:05 ` Luciano Coelho
2010-10-10 15:24 ` Shahar Levi
2010-10-11 13:55 ` Luciano Coelho
2010-10-11 14:28 ` Shahar Levi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1286538289.21349.99.camel@chilepepper \
--to=luciano.coelho@nokia.com \
--cc=linux-wireless@vger.kernel.org \
--cc=shahar_levi@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).