linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: Christian Lamparter <chunkeey@googlemail.com>
Cc: linux-wireless <linux-wireless@vger.kernel.org>,
	"John W. Linville" <linville@tuxdriver.com>,
	Ben Greear <greearb@candelatech.com>,
	rainbow lum <rainbowlum@gmail.com>
Subject: Re: phyX enumeration conflict
Date: Sun, 10 Oct 2010 10:16:44 +0200	[thread overview]
Message-ID: <1286698604.3547.7.camel@jlt3.sipsolutions.net> (raw)
In-Reply-To: <1286698152.3547.4.camel@jlt3.sipsolutions.net>

On Sun, 2010-10-10 at 10:09 +0200, Johannes Berg wrote:

> The commit failed to take into account that allocated wireless devices
> (wiphys) are not added into the device list upon allocation, but only
> when they are registered. Therefore, it opened up a race between
> allocating and registering a name, so that if two processes allocate and
> register concurrently ("alloc, alloc, register, register" rather than
> "alloc, register, alloc, register") the code will attempt to use the
> same name twice.

And as for the actual feature, as far as I'm concerned the discussion
ends here because we otherwise need to use something as complex as idr.
A udev rule can't break the kernel and works just as well, even if
you'll have to use a different namespace, i.e. not "phy%d" -- use say
"wiphy%d" instead.

johannes


  reply	other threads:[~2010-10-10  8:16 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-10-08 19:59 phyX enumeration conflict Christian Lamparter
2010-10-10  8:09 ` Johannes Berg
2010-10-10  8:16   ` Johannes Berg [this message]
2010-10-10 15:39     ` Ben Greear
2010-10-10 16:43       ` Johannes Berg
2010-10-11 17:26         ` Ben Greear
2010-10-11 17:34           ` Johannes Berg
2010-10-11 17:46             ` Ben Greear
2010-10-11 17:56               ` Johannes Berg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1286698604.3547.7.camel@jlt3.sipsolutions.net \
    --to=johannes@sipsolutions.net \
    --cc=chunkeey@googlemail.com \
    --cc=greearb@candelatech.com \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    --cc=rainbowlum@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).