From: Johannes Berg <johannes@sipsolutions.net>
To: gerrit@erg.abdn.ac.uk
Cc: "John W. Linville" <linville@tuxdriver.com>,
linux-wireless@vger.kernel.org
Subject: Re: [Patch 1/1] wext: fix 32/64 bit alignment issue for 'point' type
Date: Mon, 11 Oct 2010 14:00:32 +0200 [thread overview]
Message-ID: <1286798432.3634.39.camel@jlt3.sipsolutions.net> (raw)
In-Reply-To: <56374.148.187.160.35.1286798194.squirrel@148.187.160.35>
On Mon, 2010-10-11 at 12:56 +0100, gerrit@erg.abdn.ac.uk wrote:
> > However, I don't understand this patch. Your original patch would have
> > fixed this just as well, since after it
> >
> > IW_EV_POINT_PK_LEN - IW_EV_LCP_PK_LEN
> >
> > would be
> >
> > (IW_EV_LCP_PK_LEN + 4) - IW_EV_LCP_PK_LEN == 4
> >
> > and at the same time fixes the userspace problem, if anyone really wants
> > to use wext in new applications that don't use iwlib still...
> >
> Good catch, this is much better (I got lost in all the other constants).
> I will check if I have not missed anything and resubmit if there are no
> side effects.
Alright, thanks. I'm pretty sure you can't have missed anything, since
git grep for the constant shows only this single use, and iwlib ships a
header file that already contains your correction :-)
I'm not sure if there's a real or perceived length limit on git commit
logs, but it might be nice to archive your discussion of the problem
(today's, I mean) in the git log.
Anyway, thanks for investigating this!
johannes
next prev parent reply other threads:[~2010-10-11 12:00 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-30 10:25 [Patch 1/1] wext: fix 32/64 bit alignment issue for 'point' type Gerrit Renker
2010-09-30 14:38 ` Johannes Berg
2010-09-30 14:40 ` Johannes Berg
2010-10-01 7:22 ` gerrit
2010-10-01 8:30 ` Johannes Berg
2010-10-11 5:14 ` Gerrit Renker
2010-10-11 9:55 ` Johannes Berg
2010-10-11 11:56 ` gerrit
2010-10-11 12:00 ` Johannes Berg [this message]
2010-10-12 5:07 ` [Patch v2 1/1] wext: fix alignment problem in serializing 'struct iw_point' Gerrit Renker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1286798432.3634.39.camel@jlt3.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=gerrit@erg.abdn.ac.uk \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).