linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: greearb@candelatech.com
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH 1/2] wireless:  Support wiphy_renamed hook for drivers.
Date: Mon, 11 Oct 2010 20:46:11 +0200	[thread overview]
Message-ID: <1286822771.3634.85.camel@jlt3.sipsolutions.net> (raw)
In-Reply-To: <1286822639.3634.84.camel@jlt3.sipsolutions.net>

I think you should just do this (untested):

--- wireless-testing.orig/drivers/net/wireless/ath/ath5k/debug.c	2010-10-11 20:44:26.000000000 +0200
+++ wireless-testing/drivers/net/wireless/ath/ath5k/debug.c	2010-10-11 20:45:26.000000000 +0200
@@ -71,8 +71,6 @@ module_param_named(debug, ath5k_debug, u
 #include "reg.h"
 #include "ani.h"
 
-static struct dentry *ath5k_global_debugfs;
-
 static int ath5k_debugfs_open(struct inode *inode, struct file *file)
 {
 	file->private_data = inode->i_private;
@@ -884,7 +882,6 @@ static const struct file_operations fops
 void
 ath5k_debug_init(void)
 {
-	ath5k_global_debugfs = debugfs_create_dir("ath5k", NULL);
 }
 
 void
@@ -892,8 +889,8 @@ ath5k_debug_init_device(struct ath5k_sof
 {
 	sc->debug.level = ath5k_debug;
 
-	sc->debug.debugfs_phydir = debugfs_create_dir(wiphy_name(sc->hw->wiphy),
-				ath5k_global_debugfs);
+	sc->debug.debugfs_phydir = debugfs_create_dir("ath5k",
+				sc->hw->wiphy->debugfsdir);
 
 	sc->debug.debugfs_debug = debugfs_create_file("debug",
 				S_IWUSR | S_IRUSR,
@@ -936,7 +933,6 @@ ath5k_debug_init_device(struct ath5k_sof
 void
 ath5k_debug_finish(void)
 {
-	debugfs_remove(ath5k_global_debugfs);
 }
 
 void



  reply	other threads:[~2010-10-11 18:46 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-10-11 18:42 [PATCH 1/2] wireless: Support wiphy_renamed hook for drivers greearb
2010-10-11 18:42 ` [PATCH 2/2] ath5k: Support wiphy_renamed operation greearb
2010-10-11 18:43 ` [PATCH 1/2] wireless: Support wiphy_renamed hook for drivers Johannes Berg
2010-10-11 18:46   ` Johannes Berg [this message]
2010-10-11 18:48     ` Ben Greear
2010-10-11 19:07     ` Ben Greear
2010-10-11 19:28       ` Johannes Berg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1286822771.3634.85.camel@jlt3.sipsolutions.net \
    --to=johannes@sipsolutions.net \
    --cc=greearb@candelatech.com \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).