From: Johannes Berg <johannes@sipsolutions.net>
To: Ben Greear <greearb@candelatech.com>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH 1/2] wireless: Support wiphy_renamed hook for drivers.
Date: Mon, 11 Oct 2010 21:28:59 +0200 [thread overview]
Message-ID: <1286825339.3634.86.camel@jlt3.sipsolutions.net> (raw)
In-Reply-To: <4CB3605D.1040509@candelatech.com>
On Mon, 2010-10-11 at 12:07 -0700, Ben Greear wrote:
> On 10/11/2010 11:46 AM, Johannes Berg wrote:
> > I think you should just do this (untested):
>
> > void
> > @@ -892,8 +889,8 @@ ath5k_debug_init_device(struct ath5k_sof
> > {
> > sc->debug.level = ath5k_debug;
> >
> > - sc->debug.debugfs_phydir = debugfs_create_dir(wiphy_name(sc->hw->wiphy),
> > - ath5k_global_debugfs);
> > + sc->debug.debugfs_phydir = debugfs_create_dir("ath5k",
> > + sc->hw->wiphy->debugfsdir);
>
> This fails to work because sc->hw->wiphy->debugfsdir is null when this
> method is called...
Then it needs to be after registering with mac80211 -- shouldn't really
change much though.
johannes
prev parent reply other threads:[~2010-10-11 19:29 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-11 18:42 [PATCH 1/2] wireless: Support wiphy_renamed hook for drivers greearb
2010-10-11 18:42 ` [PATCH 2/2] ath5k: Support wiphy_renamed operation greearb
2010-10-11 18:43 ` [PATCH 1/2] wireless: Support wiphy_renamed hook for drivers Johannes Berg
2010-10-11 18:46 ` Johannes Berg
2010-10-11 18:48 ` Ben Greear
2010-10-11 19:07 ` Ben Greear
2010-10-11 19:28 ` Johannes Berg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1286825339.3634.86.camel@jlt3.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=greearb@candelatech.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).