From: Luciano Coelho <luciano.coelho@nokia.com>
To: "ext csanjay@mistralsolutions.com" <csanjay@mistralsolutions.com>
Cc: "linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: Re: [RFC: WL1271 DC supprot on OMAP3EVM 0/5]
Date: Wed, 13 Oct 2010 15:37:54 +0300 [thread overview]
Message-ID: <1286973475.18871.27.camel@chilepepper> (raw)
In-Reply-To: <1286967439-705-1-git-send-email-csanjay@mistralsolutions.com>
Hi Sanjay,
On Wed, 2010-10-13 at 12:57 +0200, ext csanjay@mistralsolutions.com
wrote:
> From: Sanjay Kumar Champati <csanjay@mistralsolutions.com>
>
>
> Sanjay Kumar Champati (5):
> ARM: Supported MMC 2 features for OMAP3EVM
> ARM: Supported for Standard SDIO driver on OMAP3EVM for WL1271 DC
> ARM: Supported for BT enable on OMAP3EVM for WL1271 DC
> ARM: Added ALSA audio support for WL1271 DC over the PCM interface
> (OMAP37XX)
> Supported BT and WLAN configuration for WL1271 over the OMAP37XX
Nobody (or at least most of us) don't even understand what exactly the
purpose of your patchset it. Can you try to explain what you're trying
to achieve?
Also, you should clean things up, put platform-specific things where
they belong etc. You really must review your implementation from an
architectural point of view. If you have questions, ask here first. In
most cases a patch describes things better than a thousand words, but it
is certainly not the case here. ;)
--
Cheers,
Luca.
prev parent reply other threads:[~2010-10-13 12:38 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-13 10:57 [RFC: WL1271 DC supprot on OMAP3EVM 0/5] csanjay
2010-10-13 10:57 ` [RFC: WL1271 DC supprot on OMAP3EVM 1/5] ARM: Supported MMC 2 features for OMAP3EVM csanjay
2010-10-13 10:57 ` [RFC: WL1271 DC supprot on OMAP3EVM 2/5] ARM: Supported for Standard SDIO driver on OMAP3EVM for WL1271 DC csanjay
2010-10-13 11:17 ` Varadarajan, Charulatha
2010-10-13 11:32 ` Johannes Berg
2010-10-13 10:57 ` [RFC: WL1271 DC supprot on OMAP3EVM 3/5] ARM: Supported for BT enable " csanjay
2010-10-13 10:57 ` [RFC: WL1271 DC supprot on OMAP3EVM 4/5] ARM: Added ALSA audio support for WL1271 DC over the PCM interface (OMAP37XX) csanjay
2010-10-13 10:57 ` [RFC: WL1271 DC supprot on OMAP3EVM 5/5] Supported BT and WLAN configuration for WL1271 over the OMAP37XX csanjay
2010-10-13 11:54 ` [RFC: WL1271 DC supprot on OMAP3EVM 0/5] Ohad Ben-Cohen
2010-10-13 12:37 ` Luciano Coelho [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1286973475.18871.27.camel@chilepepper \
--to=luciano.coelho@nokia.com \
--cc=csanjay@mistralsolutions.com \
--cc=linux-omap@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).