From: "Guy, Wey-Yi" <wey-yi.w.guy@intel.com>
To: Stanislaw Gruszka <sgruszka@redhat.com>
Cc: Johannes Berg <johannes@sipsolutions.net>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH 2/2] iwlwifi: one less commit_rxon while scan
Date: Thu, 14 Oct 2010 08:54:39 -0700 [thread overview]
Message-ID: <1287071679.13051.10.camel@wwguy-ubuntu> (raw)
In-Reply-To: <20101014084238.GB2286@redhat.com>
Hi Stanislaw,
On Thu, 2010-10-14 at 01:42 -0700, Stanislaw Gruszka wrote:
> On Wed, Oct 13, 2010 at 03:39:53PM +0200, Stanislaw Gruszka wrote:
> > Almost anywhere in the code we avoid committing rxon while performing
> > scan, and make rxon commit when scan complete. Some current patches do
> > not follow that rule. We have that problem at least in
> > iwlagn_confirue_filter(), iwl_update_chain_flags() and
> > iwl_bg_bt_full_concurrency().
>
> Any comments about iwl_update_chain_flags, iwl_bg_bt_full_concurrency ?
> I would like to know how to deal with them, should we deffer commit_rxon
> to scan complete, or cancel the scan. Or maybe this is no problem
> at all, because in example committing rxon vs scan was problem of
> older firmware?
>
iwl_update_chain_flags() is used when PSP mode change,
iwl_bg_bt_full_concurrency() is used only for BT coex and in BT full
concurrency mode. For both case, I do not see any reason we can not
defer to scan complete.
Thanks
Wey
next prev parent reply other threads:[~2010-10-14 15:55 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-13 13:39 [PATCH 1/2] iwlwifi: fix set_tx_power vs scan Stanislaw Gruszka
2010-10-13 13:39 ` [PATCH 2/2] iwlwifi: one less commit_rxon while scan Stanislaw Gruszka
2010-10-14 8:42 ` Stanislaw Gruszka
2010-10-14 15:54 ` Guy, Wey-Yi [this message]
2010-10-15 14:51 ` Stanislaw Gruszka
2010-10-15 16:00 ` Guy, Wey-Yi
2010-10-13 15:18 ` [PATCH 1/2] iwlwifi: fix set_tx_power vs scan Guy, Wey-Yi
2010-10-14 8:32 ` Stanislaw Gruszka
2010-10-21 13:13 ` Stanislaw Gruszka
2010-10-21 14:26 ` Guy, Wey-Yi
2010-10-22 12:56 ` Stanislaw Gruszka
2010-10-22 14:39 ` Guy, Wey-Yi
2010-10-22 15:04 ` Stanislaw Gruszka
2010-10-22 16:51 ` Dan Williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1287071679.13051.10.camel@wwguy-ubuntu \
--to=wey-yi.w.guy@intel.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=sgruszka@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).