* [PATCH 0/3] wireless: a few sparse fixes
@ 2010-10-20 13:59 Luis R. Rodriguez
2010-10-20 13:59 ` [PATCH 1/3] ath: make ath_hw_keysetmac() static Luis R. Rodriguez
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Luis R. Rodriguez @ 2010-10-20 13:59 UTC (permalink / raw)
To: linville; +Cc: linux-wireless, Luis R. Rodriguez
Just a few sparse fixes which were poking my eyes out.
Luis R. Rodriguez (3):
ath: make ath_hw_keysetmac() static
ath: make ath_hw_set_keycache_entry() static
ath5k: make ath5k_update_bssid_mask_and_opmode() static
drivers/net/wireless/ath/ath5k/base.c | 4 ++--
drivers/net/wireless/ath/key.c | 9 +++++----
2 files changed, 7 insertions(+), 6 deletions(-)
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH 1/3] ath: make ath_hw_keysetmac() static
2010-10-20 13:59 [PATCH 0/3] wireless: a few sparse fixes Luis R. Rodriguez
@ 2010-10-20 13:59 ` Luis R. Rodriguez
2010-10-20 13:59 ` [PATCH 2/3] ath: make ath_hw_set_keycache_entry() static Luis R. Rodriguez
2010-10-20 13:59 ` [PATCH 3/3] ath5k: make ath5k_update_bssid_mask_and_opmode() static Luis R. Rodriguez
2 siblings, 0 replies; 4+ messages in thread
From: Luis R. Rodriguez @ 2010-10-20 13:59 UTC (permalink / raw)
To: linville; +Cc: linux-wireless, Luis R. Rodriguez
This fixes this sparse warning:
CHECK drivers/net/wireless/ath/key.c
drivers/net/wireless/ath/key.c:70:6: warning: symbol 'ath_hw_keysetmac' was not declared. Should it be static?
Signed-off-by: Luis R. Rodriguez <lrodriguez@atheros.com>
---
drivers/net/wireless/ath/key.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/drivers/net/wireless/ath/key.c b/drivers/net/wireless/ath/key.c
index bd21a4d..1e9aa32 100644
--- a/drivers/net/wireless/ath/key.c
+++ b/drivers/net/wireless/ath/key.c
@@ -67,7 +67,8 @@ bool ath_hw_keyreset(struct ath_common *common, u16 entry)
}
EXPORT_SYMBOL(ath_hw_keyreset);
-bool ath_hw_keysetmac(struct ath_common *common, u16 entry, const u8 *mac)
+static bool ath_hw_keysetmac(struct ath_common *common,
+ u16 entry, const u8 *mac)
{
u32 macHi, macLo;
u32 unicast_flag = AR_KEYTABLE_VALID;
--
1.7.0.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH 2/3] ath: make ath_hw_set_keycache_entry() static
2010-10-20 13:59 [PATCH 0/3] wireless: a few sparse fixes Luis R. Rodriguez
2010-10-20 13:59 ` [PATCH 1/3] ath: make ath_hw_keysetmac() static Luis R. Rodriguez
@ 2010-10-20 13:59 ` Luis R. Rodriguez
2010-10-20 13:59 ` [PATCH 3/3] ath5k: make ath5k_update_bssid_mask_and_opmode() static Luis R. Rodriguez
2 siblings, 0 replies; 4+ messages in thread
From: Luis R. Rodriguez @ 2010-10-20 13:59 UTC (permalink / raw)
To: linville; +Cc: linux-wireless, Luis R. Rodriguez
This fixes this sparse warning:
CHECK drivers/net/wireless/ath/key.c
drivers/net/wireless/ath/key.c:110:6: warning: symbol
'ath_hw_set_keycache_entry' was not declared. Should it be static?
Signed-off-by: Luis R. Rodriguez <lrodriguez@atheros.com>
---
drivers/net/wireless/ath/key.c | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/net/wireless/ath/key.c b/drivers/net/wireless/ath/key.c
index 1e9aa32..62e3dac 100644
--- a/drivers/net/wireless/ath/key.c
+++ b/drivers/net/wireless/ath/key.c
@@ -108,9 +108,9 @@ static bool ath_hw_keysetmac(struct ath_common *common,
return true;
}
-bool ath_hw_set_keycache_entry(struct ath_common *common, u16 entry,
- const struct ath_keyval *k,
- const u8 *mac)
+static bool ath_hw_set_keycache_entry(struct ath_common *common, u16 entry,
+ const struct ath_keyval *k,
+ const u8 *mac)
{
void *ah = common->ah;
u32 key0, key1, key2, key3, key4;
--
1.7.0.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH 3/3] ath5k: make ath5k_update_bssid_mask_and_opmode() static
2010-10-20 13:59 [PATCH 0/3] wireless: a few sparse fixes Luis R. Rodriguez
2010-10-20 13:59 ` [PATCH 1/3] ath: make ath_hw_keysetmac() static Luis R. Rodriguez
2010-10-20 13:59 ` [PATCH 2/3] ath: make ath_hw_set_keycache_entry() static Luis R. Rodriguez
@ 2010-10-20 13:59 ` Luis R. Rodriguez
2 siblings, 0 replies; 4+ messages in thread
From: Luis R. Rodriguez @ 2010-10-20 13:59 UTC (permalink / raw)
To: linville; +Cc: linux-wireless, Luis R. Rodriguez
This fixes this sparse warning:
CHECK drivers/net/wireless/ath/ath5k/base.c
drivers/net/wireless/ath/ath5k/base.c:569:6: warning: symbol
'ath5k_update_bssid_mask_and_opmode' was not declared. Should it be static?
Signed-off-by: Luis R. Rodriguez <lrodriguez@atheros.com>
---
drivers/net/wireless/ath/ath5k/base.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/wireless/ath/ath5k/base.c b/drivers/net/wireless/ath/ath5k/base.c
index 8251946..aeb258a 100644
--- a/drivers/net/wireless/ath/ath5k/base.c
+++ b/drivers/net/wireless/ath/ath5k/base.c
@@ -566,8 +566,8 @@ static void ath_do_set_opmode(struct ath5k_softc *sc)
sc->opmode, ath_opmode_to_string(sc->opmode));
}
-void ath5k_update_bssid_mask_and_opmode(struct ath5k_softc *sc,
- struct ieee80211_vif *vif)
+static void ath5k_update_bssid_mask_and_opmode(struct ath5k_softc *sc,
+ struct ieee80211_vif *vif)
{
struct ath_common *common = ath5k_hw_common(sc->ah);
struct ath_vif_iter_data iter_data;
--
1.7.0.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2010-10-20 14:01 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-10-20 13:59 [PATCH 0/3] wireless: a few sparse fixes Luis R. Rodriguez
2010-10-20 13:59 ` [PATCH 1/3] ath: make ath_hw_keysetmac() static Luis R. Rodriguez
2010-10-20 13:59 ` [PATCH 2/3] ath: make ath_hw_set_keycache_entry() static Luis R. Rodriguez
2010-10-20 13:59 ` [PATCH 3/3] ath5k: make ath5k_update_bssid_mask_and_opmode() static Luis R. Rodriguez
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).