* [PATCH] wl1271: exit ELP mode when setting enabled rates in tx
@ 2010-10-20 12:21 luciano.coelho
2010-10-20 13:06 ` Tuomas Katila
0 siblings, 1 reply; 3+ messages in thread
From: luciano.coelho @ 2010-10-20 12:21 UTC (permalink / raw)
To: linux-wireless
From: Luciano Coelho <luciano.coelho@nokia.com>
This bug was being triggered by a call to acx_rate_policies in tx_work
without calling ps_elp_wakeup first. If we have full PSM enabled, this
happens rather often, immediately after association.
Reported-by: Tuomas Katila <ext-tuomas.2.katila@nokia.com>
Signed-off-by: Luciano Coelho <luciano.coelho@nokia.com>
---
drivers/net/wireless/wl12xx/wl1271_tx.c | 5 +++++
1 files changed, 5 insertions(+), 0 deletions(-)
diff --git a/drivers/net/wireless/wl12xx/wl1271_tx.c b/drivers/net/wireless/wl12xx/wl1271_tx.c
index 46fafe0..279be5b 100644
--- a/drivers/net/wireless/wl12xx/wl1271_tx.c
+++ b/drivers/net/wireless/wl12xx/wl1271_tx.c
@@ -261,6 +261,11 @@ void wl1271_tx_work_locked(struct wl1271 *wl)
/* if rates have changed, re-configure the rate policy */
if (unlikely(sta_rates)) {
+ ret = wl1271_ps_elp_wakeup(wl, false);
+ if (ret < 0)
+ goto out;
+ woken_up = true;
+
wl->rate_set = wl1271_tx_enabled_rates_get(wl, sta_rates);
wl1271_acx_rate_policies(wl);
}
--
1.7.0.4
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] wl1271: exit ELP mode when setting enabled rates in tx
2010-10-20 12:21 [PATCH] wl1271: exit ELP mode when setting enabled rates in tx luciano.coelho
@ 2010-10-20 13:06 ` Tuomas Katila
2010-10-20 18:16 ` Luciano Coelho
0 siblings, 1 reply; 3+ messages in thread
From: Tuomas Katila @ 2010-10-20 13:06 UTC (permalink / raw)
To: ext luciano.coelho@nokia.com; +Cc: linux-wireless@vger.kernel.org
On Wed, 2010-10-20 at 14:21 +0200, ext luciano.coelho@nokia.com wrote:
> From: Luciano Coelho <luciano.coelho@nokia.com>
>
> This bug was being triggered by a call to acx_rate_policies in tx_work
> without calling ps_elp_wakeup first. If we have full PSM enabled, this
> happens rather often, immediately after association.
>
> Reported-by: Tuomas Katila <ext-tuomas.2.katila@nokia.com>
> Signed-off-by: Luciano Coelho <luciano.coelho@nokia.com>
> ---
Tested-by: Tuomas Katila <ext-tuomas.2.katila@nokia.com>
I couldn't reproduce the error after tens of tries.
-Tuomas
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] wl1271: exit ELP mode when setting enabled rates in tx
2010-10-20 13:06 ` Tuomas Katila
@ 2010-10-20 18:16 ` Luciano Coelho
0 siblings, 0 replies; 3+ messages in thread
From: Luciano Coelho @ 2010-10-20 18:16 UTC (permalink / raw)
To: Tuomas Katila; +Cc: linux-wireless@vger.kernel.org
On Wed, 2010-10-20 at 15:06 +0200, Tuomas Katila wrote:
> On Wed, 2010-10-20 at 14:21 +0200, ext luciano.coelho@nokia.com wrote:
> > From: Luciano Coelho <luciano.coelho@nokia.com>
> >
> > This bug was being triggered by a call to acx_rate_policies in tx_work
> > without calling ps_elp_wakeup first. If we have full PSM enabled, this
> > happens rather often, immediately after association.
> >
> > Reported-by: Tuomas Katila <ext-tuomas.2.katila@nokia.com>
> > Signed-off-by: Luciano Coelho <luciano.coelho@nokia.com>
> > ---
>
> Tested-by: Tuomas Katila <ext-tuomas.2.katila@nokia.com>
>
> I couldn't reproduce the error after tens of tries.
Thanks Tuomas! Applied.
--
Cheers,
Luca.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-10-20 18:16 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-10-20 12:21 [PATCH] wl1271: exit ELP mode when setting enabled rates in tx luciano.coelho
2010-10-20 13:06 ` Tuomas Katila
2010-10-20 18:16 ` Luciano Coelho
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).