From: "Michael Büsch" <mb@bu3sch.de>
To: Larry Finger <Larry.Finger@lwfinger.net>
Cc: John W Linville <linville@tuxdriver.com>,
b43-dev@lists.infradead.org, linux-wireless@vger.kernel.org
Subject: Re: [PATCH] ssb: Clear RETRY_TIMEOUT in PCI Configuration for normal devices
Date: Wed, 20 Oct 2010 22:52:21 +0200 [thread overview]
Message-ID: <1287607941.2023.1.camel@maggie> (raw)
In-Reply-To: <4cbf03d5.sBoVK5FZiEsbJ8xu%Larry.Finger@lwfinger.net> (sfid-20101020_165935_779270_769119B3)
On Wed, 2010-10-20 at 09:59 -0500, Larry Finger wrote:
> The previous patch of this type fixed the case where a PCI device is behind
> an SSB->PCI bridge as found on an embedded device. This one treats the normal
> case of a "normal" Broadcom wireless PCI core on an SSB interconnect.
Note that the other patch is not needed anymore, if this is applied.
Also note that this patch will also have an effect on b44 hardware.
Do we want that?
> MMIO log traces obtained using the Broadcom wl hybrid driver show that
> the RETRY_TIMEOUT register (0x41) in PCI configuration space is cleared
> if non-zero. Similar code found in other drivers such as ipw2100 show
> this operation is needed to keep PCI Tx retries from interfering with
> C3 CPU state. There are no known cases where omission of this code has
> caused a problem, but this patch is offered just in case such a situation
> occurs.
--
Greetings Michael.
prev parent reply other threads:[~2010-10-20 20:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-20 14:59 [PATCH] ssb: Clear RETRY_TIMEOUT in PCI Configuration for normal devices Larry Finger
2010-10-20 20:52 ` Michael Büsch [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1287607941.2023.1.camel@maggie \
--to=mb@bu3sch.de \
--cc=Larry.Finger@lwfinger.net \
--cc=b43-dev@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).