From: Johannes Berg <johannes@sipsolutions.net>
To: "Luis R. Rodriguez" <lrodriguez@atheros.com>
Cc: linville@tuxdriver.com, linux-wireless@vger.kernel.org,
amod.bodas@atheros.com, pstew@google.com, stable@kernel.org
Subject: Re: [RFT] mac80211: fix null pointer dereference on ieee80211_stop_tx_ba_session()
Date: Mon, 25 Oct 2010 10:23:32 +0200 [thread overview]
Message-ID: <1287995012.3587.2.camel@jlt3.sipsolutions.net> (raw)
In-Reply-To: <1287803778-10330-1-git-send-email-lrodriguez@atheros.com>
On Fri, 2010-10-22 at 20:16 -0700, Luis R. Rodriguez wrote:
> RCU was not being used so we could race against the free'ing of the TID.
> spin_lock_bh(&sta->lock);
> - tid_tx = sta->ampdu_mlme.tid_tx[tid];
> + tid_tx = rcu_dereference(sta->ampdu_mlme.tid_tx[tid]);
As I mentioned to Luis on IRC, I believe that the spinlock is held
across all assignments to ampdu_mlme.tid_tx, so this is definitely not
necessary (nor really correct). If there is a place that doesn't hold
the spinlock that may be a bug, but a cursory look suggested that all
places hold the lock correctly.
johannes
next prev parent reply other threads:[~2010-10-25 8:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-23 3:16 [RFT] mac80211: fix null pointer dereference on ieee80211_stop_tx_ba_session() Luis R. Rodriguez
2010-10-25 8:23 ` Johannes Berg [this message]
[not found] ` <AANLkTinqpj1O9Rpnk13JM-pFB_CkYfHeQvFpjQktQOD1@mail.gmail.com>
2010-10-26 5:50 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1287995012.3587.2.camel@jlt3.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=amod.bodas@atheros.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=lrodriguez@atheros.com \
--cc=pstew@google.com \
--cc=stable@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).