linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: Bruno Randolf <br1@einfach.org>
Cc: linville@tuxdriver.com, linux-wireless@vger.kernel.org
Subject: Re: [PATCH] iw: Add ibss join parameter for beacon interval
Date: Mon, 25 Oct 2010 10:26:16 +0200	[thread overview]
Message-ID: <1287995176.3587.4.camel@jlt3.sipsolutions.net> (raw)
In-Reply-To: <20101019073141.14128.29518.stgit@localhost6.localdomain6>

On Tue, 2010-10-19 at 16:31 +0900, Bruno Randolf wrote:

> +	if (argc > 1 && strcmp(argv[0], "bintval") == 0) {

I'd prefer this to be called just "bi" or fully spelt out.

>  	NL80211_CMD_LEAVE_IBSS, 0, CIB_NETDEV, leave_ibss,
>  	"Leave the current IBSS cell.");
>  COMMAND(ibss, join,
> -	"<SSID> <freq in MHz> [fixed-freq] [<fixed bssid>] "
> +	"<SSID> <freq in MHz> [fixed-freq] [<fixed bssid>] [bintval <ms>] "

It's not in ms, but TU. *sigh*

johannes


  reply	other threads:[~2010-10-25  8:29 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-10-19  7:31 [PATCH] iw: Add ibss join parameter for beacon interval Bruno Randolf
2010-10-25  8:26 ` Johannes Berg [this message]
2010-10-26  2:37   ` Bruno Randolf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1287995176.3587.4.camel@jlt3.sipsolutions.net \
    --to=johannes@sipsolutions.net \
    --cc=br1@einfach.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).