From: Luciano Coelho <luciano.coelho@nokia.com>
To: Nicolas Kaiser <nikai@nikai.net>
Cc: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Larry Finger <Larry.Finger@lwfinger.net>
Subject: Re: [PATCH] wireless/wl1271: remove redundant if-statement
Date: Mon, 25 Oct 2010 16:10:45 +0300 [thread overview]
Message-ID: <1288012245.21130.24.camel@chilepepper> (raw)
In-Reply-To: <4CC4B210.2010608@lwfinger.net>
On Mon, 2010-10-25 at 00:24 +0200, ext Larry Finger wrote:
> On 10/24/2010 05:07 PM, Nicolas Kaiser wrote:
> > Apparently the return value of wl1271_ps_elp_sleep never gets
> > checked anyway.
>
> The patch is fine, but this comment is a little misleading as
> wl1271_ps_elp_sleep() is void and cannot return a value.
Yes, this patch is good, but please rewrite the description, as Larry
suggested.
--
Cheers,
Luca.
next prev parent reply other threads:[~2010-10-25 13:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-24 22:07 [PATCH] wireless/wl1271: remove redundant if-statement Nicolas Kaiser
2010-10-24 22:24 ` Larry Finger
2010-10-25 13:10 ` Luciano Coelho [this message]
2010-10-25 13:30 ` [PATCH] wireless/wl1271: remove redundant if-statement v2 Nicolas Kaiser
2010-10-26 10:27 ` Luciano Coelho
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1288012245.21130.24.camel@chilepepper \
--to=luciano.coelho@nokia.com \
--cc=Larry.Finger@lwfinger.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=nikai@nikai.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).