From: Luciano Coelho <luciano.coelho@nokia.com>
To: "juuso.oikarinen@nokia.com" <juuso.oikarinen@nokia.com>
Cc: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH] wl1271: Fix RX path stall
Date: Tue, 26 Oct 2010 13:18:10 +0300 [thread overview]
Message-ID: <1288088290.27698.0.camel@chilepepper> (raw)
In-Reply-To: <1287998669-27209-1-git-send-email-juuso.oikarinen@nokia.com>
On Mon, 2010-10-25 at 11:24 +0200, juuso.oikarinen@nokia.com wrote:
> From: Juuso Oikarinen <juuso.oikarinen@nokia.com>
>
> The wl1271_rx function loops through packets in an aggregated buffer. Each
> packet in the buffer is handled by a call to wl1271_rx_handle_data, which will
> fail if skb memory allocation fails or production mode is enabled. These
> failures currently prevent the rx counters to be incremented, thus causing the
> rx loop to run forever.
>
> Fix this by ignoring error codes reported wl1271_rx_handle_data function.
> This essentially means that frames will be dropped in production mode, which
> is the intetion, and frames will be dropped if memory allocation fails, which
> is a decent way to recover from that situation.
>
> Signed-off-by: Juuso Oikarinen <juuso.oikarinen@nokia.com>
> ---
Reviewed-by: Luciano Coelho <luciano.coelho@nokia.com>
And applied to the wl12xx tree. Thank you!
--
Cheers,
Luca.
prev parent reply other threads:[~2010-10-26 10:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-25 9:24 [PATCH] wl1271: Fix RX path stall juuso.oikarinen
2010-10-25 12:31 ` Tuomas Katila
2010-10-26 10:18 ` Luciano Coelho [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1288088290.27698.0.camel@chilepepper \
--to=luciano.coelho@nokia.com \
--cc=juuso.oikarinen@nokia.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).