From: Luciano Coelho <luciano.coelho@nokia.com>
To: ext Nicolas Kaiser <nikai@nikai.net>
Cc: Larry Finger <Larry.Finger@lwfinger.net>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] wireless/wl1271: remove redundant if-statement v2
Date: Tue, 26 Oct 2010 13:27:44 +0300 [thread overview]
Message-ID: <1288088864.27698.1.camel@chilepepper> (raw)
In-Reply-To: <20101025153003.3aa7c168@absol.kitzblitz>
On Mon, 2010-10-25 at 15:30 +0200, ext Nicolas Kaiser wrote:
> wl1271_ps_elp_sleep() is void and cannot return a value.
>
> Signed-off-by: Nicolas Kaiser <nikai@nikai.net>
> ---
> Sorry for the poor wording of the initial description.
>
> drivers/net/wireless/wl12xx/wl1271_event.c | 2 --
> 1 files changed, 0 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/wireless/wl12xx/wl1271_event.c b/drivers/net/wireless/wl12xx/wl1271_event.c
> index 7b3f503..38ccef7 100644
> --- a/drivers/net/wireless/wl12xx/wl1271_event.c
> +++ b/drivers/net/wireless/wl12xx/wl1271_event.c
> @@ -134,8 +134,6 @@ static int wl1271_event_ps_report(struct wl1271 *wl,
>
> /* go to extremely low power mode */
> wl1271_ps_elp_sleep(wl);
> - if (ret < 0)
> - break;
> break;
> case EVENT_EXIT_POWER_SAVE_FAIL:
> wl1271_debug(DEBUG_PSM, "PSM exit failed");
Reviewed-by: Luciano Coelho <luciano.coelho@nokia.com>
Thanks! Applied to the wl12xx tree.
--
Cheers,
Luca.
prev parent reply other threads:[~2010-10-26 10:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-24 22:07 [PATCH] wireless/wl1271: remove redundant if-statement Nicolas Kaiser
2010-10-24 22:24 ` Larry Finger
2010-10-25 13:10 ` Luciano Coelho
2010-10-25 13:30 ` [PATCH] wireless/wl1271: remove redundant if-statement v2 Nicolas Kaiser
2010-10-26 10:27 ` Luciano Coelho [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1288088864.27698.1.camel@chilepepper \
--to=luciano.coelho@nokia.com \
--cc=Larry.Finger@lwfinger.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=nikai@nikai.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).