* [PATCH] wireless/wl1271: remove redundant if-statement
@ 2010-10-24 22:07 Nicolas Kaiser
2010-10-24 22:24 ` Larry Finger
0 siblings, 1 reply; 5+ messages in thread
From: Nicolas Kaiser @ 2010-10-24 22:07 UTC (permalink / raw)
To: Luciano Coelho; +Cc: linux-wireless, linux-kernel
Apparently the return value of wl1271_ps_elp_sleep never gets
checked anyway.
Signed-off-by: Nicolas Kaiser <nikai@nikai.net>
---
drivers/net/wireless/wl12xx/wl1271_event.c | 2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/drivers/net/wireless/wl12xx/wl1271_event.c b/drivers/net/wireless/wl12xx/wl1271_event.c
index 7b3f503..38ccef7 100644
--- a/drivers/net/wireless/wl12xx/wl1271_event.c
+++ b/drivers/net/wireless/wl12xx/wl1271_event.c
@@ -134,8 +134,6 @@ static int wl1271_event_ps_report(struct wl1271 *wl,
/* go to extremely low power mode */
wl1271_ps_elp_sleep(wl);
- if (ret < 0)
- break;
break;
case EVENT_EXIT_POWER_SAVE_FAIL:
wl1271_debug(DEBUG_PSM, "PSM exit failed");
--
1.7.2.2
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] wireless/wl1271: remove redundant if-statement
2010-10-24 22:07 [PATCH] wireless/wl1271: remove redundant if-statement Nicolas Kaiser
@ 2010-10-24 22:24 ` Larry Finger
2010-10-25 13:10 ` Luciano Coelho
0 siblings, 1 reply; 5+ messages in thread
From: Larry Finger @ 2010-10-24 22:24 UTC (permalink / raw)
To: Nicolas Kaiser; +Cc: Luciano Coelho, linux-wireless, linux-kernel
On 10/24/2010 05:07 PM, Nicolas Kaiser wrote:
> Apparently the return value of wl1271_ps_elp_sleep never gets
> checked anyway.
The patch is fine, but this comment is a little misleading as
wl1271_ps_elp_sleep() is void and cannot return a value.
Larry
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] wireless/wl1271: remove redundant if-statement
2010-10-24 22:24 ` Larry Finger
@ 2010-10-25 13:10 ` Luciano Coelho
2010-10-25 13:30 ` [PATCH] wireless/wl1271: remove redundant if-statement v2 Nicolas Kaiser
0 siblings, 1 reply; 5+ messages in thread
From: Luciano Coelho @ 2010-10-25 13:10 UTC (permalink / raw)
To: Nicolas Kaiser
Cc: linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org,
Larry Finger
On Mon, 2010-10-25 at 00:24 +0200, ext Larry Finger wrote:
> On 10/24/2010 05:07 PM, Nicolas Kaiser wrote:
> > Apparently the return value of wl1271_ps_elp_sleep never gets
> > checked anyway.
>
> The patch is fine, but this comment is a little misleading as
> wl1271_ps_elp_sleep() is void and cannot return a value.
Yes, this patch is good, but please rewrite the description, as Larry
suggested.
--
Cheers,
Luca.
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] wireless/wl1271: remove redundant if-statement v2
2010-10-25 13:10 ` Luciano Coelho
@ 2010-10-25 13:30 ` Nicolas Kaiser
2010-10-26 10:27 ` Luciano Coelho
0 siblings, 1 reply; 5+ messages in thread
From: Nicolas Kaiser @ 2010-10-25 13:30 UTC (permalink / raw)
To: Luciano Coelho; +Cc: Larry Finger, linux-wireless, linux-kernel
wl1271_ps_elp_sleep() is void and cannot return a value.
Signed-off-by: Nicolas Kaiser <nikai@nikai.net>
---
Sorry for the poor wording of the initial description.
drivers/net/wireless/wl12xx/wl1271_event.c | 2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/drivers/net/wireless/wl12xx/wl1271_event.c b/drivers/net/wireless/wl12xx/wl1271_event.c
index 7b3f503..38ccef7 100644
--- a/drivers/net/wireless/wl12xx/wl1271_event.c
+++ b/drivers/net/wireless/wl12xx/wl1271_event.c
@@ -134,8 +134,6 @@ static int wl1271_event_ps_report(struct wl1271 *wl,
/* go to extremely low power mode */
wl1271_ps_elp_sleep(wl);
- if (ret < 0)
- break;
break;
case EVENT_EXIT_POWER_SAVE_FAIL:
wl1271_debug(DEBUG_PSM, "PSM exit failed");
--
1.7.2.2
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] wireless/wl1271: remove redundant if-statement v2
2010-10-25 13:30 ` [PATCH] wireless/wl1271: remove redundant if-statement v2 Nicolas Kaiser
@ 2010-10-26 10:27 ` Luciano Coelho
0 siblings, 0 replies; 5+ messages in thread
From: Luciano Coelho @ 2010-10-26 10:27 UTC (permalink / raw)
To: ext Nicolas Kaiser
Cc: Larry Finger, linux-wireless@vger.kernel.org,
linux-kernel@vger.kernel.org
On Mon, 2010-10-25 at 15:30 +0200, ext Nicolas Kaiser wrote:
> wl1271_ps_elp_sleep() is void and cannot return a value.
>
> Signed-off-by: Nicolas Kaiser <nikai@nikai.net>
> ---
> Sorry for the poor wording of the initial description.
>
> drivers/net/wireless/wl12xx/wl1271_event.c | 2 --
> 1 files changed, 0 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/wireless/wl12xx/wl1271_event.c b/drivers/net/wireless/wl12xx/wl1271_event.c
> index 7b3f503..38ccef7 100644
> --- a/drivers/net/wireless/wl12xx/wl1271_event.c
> +++ b/drivers/net/wireless/wl12xx/wl1271_event.c
> @@ -134,8 +134,6 @@ static int wl1271_event_ps_report(struct wl1271 *wl,
>
> /* go to extremely low power mode */
> wl1271_ps_elp_sleep(wl);
> - if (ret < 0)
> - break;
> break;
> case EVENT_EXIT_POWER_SAVE_FAIL:
> wl1271_debug(DEBUG_PSM, "PSM exit failed");
Reviewed-by: Luciano Coelho <luciano.coelho@nokia.com>
Thanks! Applied to the wl12xx tree.
--
Cheers,
Luca.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2010-10-26 10:28 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-10-24 22:07 [PATCH] wireless/wl1271: remove redundant if-statement Nicolas Kaiser
2010-10-24 22:24 ` Larry Finger
2010-10-25 13:10 ` Luciano Coelho
2010-10-25 13:30 ` [PATCH] wireless/wl1271: remove redundant if-statement v2 Nicolas Kaiser
2010-10-26 10:27 ` Luciano Coelho
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).