From: David Woodhouse <dwmw2@infradead.org>
To: Henry Ptasinski <henryp@broadcom.com>
Cc: Nohee Ko <noheek@broadcom.com>,
"devel@linuxdriverproject.org" <devel@linuxdriverproject.org>,
Brett Rudley <brudley@broadcom.com>,
"grundler@google.com" <grundler@google.com>,
greg@kroah.com, linux-wireless@vger.kernel.org
Subject: Re: [PATCH] linux-firmware: brcm: Removed codeversion from firmware filenames.
Date: Mon, 01 Nov 2010 10:28:59 -0400 [thread overview]
Message-ID: <1288621739.26983.32.camel@macbook.infradead.org> (raw)
In-Reply-To: <20101021170810.GA15357@broadcom.com>
On Thu, 2010-10-21 at 10:08 -0700, Henry Ptasinski wrote:
> Here's a patch to rename our firmware files in the linux-firmware repo. I'll
> be sending a complimentary patch to Greg for staging-next-2.6 shortly.
>
> The basename-apiversion-codeversion construction for firmware filenames is not
> used by most other firmware files, adds complexity, and is not providing any
> value. Rename the firmware files using just basename-apiversion.
Please use the '-M' option to git diff (or whatever you're using) to
make it detect renames -- the resulting patch would be a lot shorter.
And also please ensure the filenames listed in the WHENCE file are all
correct. You don't seem to have fixed those to reflect your changes. And
in fact I think the WHENCE file is *already* listing the bcm4329 files
in the wrong directory?
--
dwmw2
next prev parent reply other threads:[~2010-11-01 14:29 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <4CBE23F4.4020104@broadcom.com>
[not found] ` <20101019233520.GA12510@kroah.com>
[not found] ` <FD96C117992C584DBC47231B1EB6F5568206D859DC@SJEXCHCCR02.corp.ad.broadcom.com>
[not found] ` <20101020004743.GB31965@kroah.com>
[not found] ` <20101020005546.GL10832@broadcom.com>
[not found] ` <20101020010320.GA370@kroah.com>
2010-10-20 2:18 ` [PATCH] staging:brcm80211:brcmfmac:change firmware/config file name Henry Ptasinski
2010-10-20 3:10 ` Greg KH
2010-10-20 11:49 ` Rafał Miłecki
2010-10-20 18:04 ` Henry Ptasinski (local)
2010-10-21 17:08 ` [PATCH] linux-firmware: brcm: Removed codeversion from firmware filenames Henry Ptasinski
2010-11-01 14:28 ` David Woodhouse [this message]
2010-12-08 20:50 ` [PATCH v2] " Henry Ptasinski
2010-12-08 22:07 ` Rafał Miłecki
2010-12-08 22:23 ` Greg KH
2010-12-08 23:35 ` Henry Ptasinski
2010-12-09 0:28 ` Rafał Miłecki
2010-12-09 1:30 ` Henry Ptasinski
2010-12-09 9:01 ` Rafał Miłecki
2010-10-21 17:10 ` Subject: [PATCH] staging: brcm80211: brcmfmac: " Henry Ptasinski
2010-10-21 18:26 ` Greg KH
2010-10-21 18:37 ` Subject: [PATCH v2] " Henry Ptasinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1288621739.26983.32.camel@macbook.infradead.org \
--to=dwmw2@infradead.org \
--cc=brudley@broadcom.com \
--cc=devel@linuxdriverproject.org \
--cc=greg@kroah.com \
--cc=grundler@google.com \
--cc=henryp@broadcom.com \
--cc=linux-wireless@vger.kernel.org \
--cc=noheek@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).