From: Luciano Coelho <luciano.coelho@nokia.com>
To: ext Eliad Peller <eliad@wizery.com>
Cc: Johannes Berg <johannes@sipsolutions.net>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH 2/2] wl1271: refactor debugfs function generation code
Date: Mon, 01 Nov 2010 21:23:23 +0200 [thread overview]
Message-ID: <1288639403.21112.50.camel@powerslave> (raw)
In-Reply-To: <1288184310-6781-2-git-send-email-eliad@wizery.com>
On Wed, 2010-10-27 at 14:58 +0200, ext Eliad Peller wrote:
> refactor wl1271_debugfs by using a format© function, instead of
> duplicating the code for each generated function.
>
> this change reduces about 3Kb from wl1271.ko
>
> Signed-off-by: Eliad Peller <eliad@wizery.com>
> ---
Looks good, thanks!
Reviewed-by: Luciano Coelho <luciano.coelho@nokia.com>
I have applied this patch, but I won't apply the one for mac80211 [1/2],
because patches for mac80211 go directly to linux-wireless.
John, can you apply patch [1/2], the mac80211 part, separately on your
tree? If Johannes agrees, of course. This one I'll send together with
my next pull request.
PS: I have fixed a couple of whitespace checkpatch warnings.
--
Cheers,
Luca.
next prev parent reply other threads:[~2010-11-01 19:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-27 12:58 [PATCH 1/2] mac80211: refactor debugfs function generation code Eliad Peller
2010-10-27 12:58 ` [PATCH 2/2] wl1271: " Eliad Peller
2010-11-01 19:23 ` Luciano Coelho [this message]
2010-11-01 21:30 ` Eliad Peller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1288639403.21112.50.camel@powerslave \
--to=luciano.coelho@nokia.com \
--cc=eliad@wizery.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox