Re: [PATCH 2/2] wl1271: add recover testmode command

[Luciano Coelho <luciano.coelho@nokia.com>]

On Mon, 2010-11-01 at 22:21 +0100, ext Gábor Stefanik wrote:
> On Mon, Nov 1, 2010 at 9:59 PM, Eliad Peller <eliad@wizery.com> wrote:
> >>> add RECOVER testmode command.
> >>> this command triggers a recovery sequence (by enqueueing a recovery_work).
> >>>
> >>> Signed-off-by: Eliad Peller <eliad@wizery.com>
> >>> ---
> >>
> >> So, the point of this patch is to allow hardware recovery from the
> >> userspace? In what kind of scenario do you need this?
> >>
> >
> > yes.
> > it's mainly for testing (or if we want to recover manually for some reason).
> > this is why i implemented it as a testmode command.
> 
> Isn't testmode for features used during regulatory testing, that the
> user should be unable to access to ensure further regulatory
> compliance?

Not exactly, it's just an interface to be used during production (and
possibly R&D) tests.  In the specific case of wl12xx, we use it for
production-line testing and for calibration and testing during R&D.

A normal user shouldn't use this by default (all distros and device
manufacturers should have it disabled in the kernel), but there's no way
to prevent a hacker from enabling it in a custom kernel.

In any case, I'm not sure I really like this idea of a HW recovery test
command.  This should really be done automatically by the driver and,
with Juuso's implementation plus the watchdog, we shouldn't really need
it.

-- 
Cheers,
Luca.