From: Johannes Berg <johannes@sipsolutions.net>
To: Luciano Coelho <luciano.coelho@nokia.com>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [RFC 03/15] nl80211: alloc and free the periodic_req data
Date: Thu, 04 Nov 2010 11:43:16 -0400 [thread overview]
Message-ID: <1288885396.3659.1.camel@jlt3.sipsolutions.net> (raw)
In-Reply-To: <1288612336-2830-4-git-send-email-luciano.coelho@nokia.com>
On Mon, 2010-11-01 at 13:52 +0200, Luciano Coelho wrote:
> + /*
> + * FIXME: Can this stay here? How will the auto-complete and other
> + * cleanup cases work?
> + */
> + kfree(rdev->periodic_req);
> + rdev->periodic_req = NULL;
No ... you want a new function that you call here, and also call the
stop into the device at netdev down from the notifier in core.c.
johannes
next prev parent reply other threads:[~2010-11-04 20:47 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-01 11:52 [RFC 00/15] Implementation of periodic scan Luciano Coelho
2010-11-01 11:52 ` [RFC 01/15] nl80211: add periodic scan commands Luciano Coelho
2010-11-04 15:42 ` Johannes Berg
2010-11-05 14:14 ` Luciano Coelho
2010-11-01 11:52 ` [RFC 02/15] cfg80211: add periodic scan request structure Luciano Coelho
2010-11-01 11:52 ` [RFC 03/15] nl80211: alloc and free the periodic_req data Luciano Coelho
2010-11-04 15:43 ` Johannes Berg [this message]
2010-11-05 14:14 ` Luciano Coelho
2010-11-01 11:52 ` [RFC 04/15] cfg80211: add periodic scan start and stop ops Luciano Coelho
2010-11-01 11:52 ` [RFC 05/15] nl80211: call periodic_start and periodic_stop Luciano Coelho
2010-11-04 15:44 ` Johannes Berg
2010-11-05 19:44 ` Luciano Coelho
2010-11-05 19:50 ` Johannes Berg
2010-11-01 11:52 ` [RFC 06/15] mac80211: add support for HW periodic scan Luciano Coelho
2010-11-04 15:45 ` Johannes Berg
2010-11-05 19:59 ` Luciano Coelho
2010-11-05 19:55 ` Johannes Berg
2010-11-11 15:33 ` Gery Kahn
2010-11-11 15:59 ` Luciano Coelho
2010-11-11 17:50 ` Johannes Berg
2010-11-01 11:52 ` [RFC 07/15] cfg80211: add periodic scan results handler Luciano Coelho
2010-11-04 15:47 ` Johannes Berg
2010-11-05 20:00 ` Luciano Coelho
2010-11-01 11:52 ` [RFC 08/15] nl80211: report periodic scan results Luciano Coelho
2010-11-01 11:52 ` [RFC 09/15] cfg80211: add channel support to periodic scan Luciano Coelho
2010-11-01 11:52 ` [RFC 10/15] nl80211: add channel support to the " Luciano Coelho
2010-11-01 11:52 ` [RFC 11/15] mac80211: pass cfg80211 periodic scan request structure down to the driver Luciano Coelho
2010-11-01 11:52 ` [RFC 12/15] cfg80211: add ssid support to periodic scan Luciano Coelho
2010-11-01 11:52 ` [RFC 13/15] nl80211: add ssid filtering support to the " Luciano Coelho
2010-11-01 11:52 ` [RFC 14/15] cfg80211: add ie support for periodic scans Luciano Coelho
2010-11-04 15:49 ` Johannes Berg
2010-11-05 20:01 ` Luciano Coelho
2010-11-01 11:52 ` [RFC 15/15] mac80211: create and pass the ies for each band in " Luciano Coelho
2010-11-04 15:51 ` [RFC 00/15] Implementation of periodic scan Johannes Berg
2010-11-04 21:46 ` Luciano Coelho
2010-11-11 15:31 ` Gery Kahn
2010-11-11 15:57 ` Luciano Coelho
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1288885396.3659.1.camel@jlt3.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=luciano.coelho@nokia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).