From: Johannes Berg <johannes@sipsolutions.net>
To: juuso.oikarinen@nokia.com
Cc: linville@tuxdriver.com, linux-wireless@vger.kernel.org
Subject: Re: [PATCH] mac80211: Add function to get probe request template for current AP
Date: Tue, 09 Nov 2010 11:47:44 -0500 [thread overview]
Message-ID: <1289321264.3660.0.camel@jlt3.sipsolutions.net> (raw)
In-Reply-To: <1289290893-6766-1-git-send-email-juuso.oikarinen@nokia.com>
On Tue, 2010-11-09 at 10:21 +0200, juuso.oikarinen@nokia.com wrote:
> +struct sk_buff *ieee80211_ap_probereq_get(struct ieee80211_hw *hw,
> + struct ieee80211_vif *vif)
> +{
> + struct ieee80211_sub_if_data *sdata = vif_to_sdata(vif);
> + struct ieee80211_if_managed *ifmgd = &sdata->u.mgd;
> + struct sk_buff *skb;
> + const u8 *ssid;
> +
> + if (WARN_ON(sdata->vif.type != NL80211_IFTYPE_STATION))
> + return NULL;
> +
> + ASSERT_MGD_MTX(ifmgd);
This is interesting locking, you will definitely need to document better
that this may only be called from within the bss_info_changed callback.
johannes
next prev parent reply other threads:[~2010-11-09 16:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-09 8:21 [PATCH] mac80211: Add function to get probe request template for current AP juuso.oikarinen
2010-11-09 16:47 ` Johannes Berg [this message]
2010-11-10 6:13 ` Juuso Oikarinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1289321264.3660.0.camel@jlt3.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=juuso.oikarinen@nokia.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).