Re: [PATCH v7 1/3] cfg80211: Add nl80211 antenna configuration

[Johannes Berg <johannes@sipsolutions.net>]

On Wed, 2010-11-10 at 16:59 +0100, Felix Fietkau wrote:
> > I'm not entirely convinced that this is a good idea. Nor that, even if
> > 11n devices were to implement it, they should all implementing their own
> > code to update the HT capabilities. However, I suppose that nothing
> > forces them to implement it, and when somebody does I can still complain
> > when they put everything into the driver.

> Drivers already need to calculate their HT capabilities based on the
> number of chains.
> If chains get masked out based on the antenna mask settings, the driver
> code would most of the time only need minor refactoring for updating the
> settings which wouldn't necessarily result in any new code duplication
> at all.

Good point.

johannes