linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Michael Büsch" <mb@bu3sch.de>
To: "John W. Linville" <linville@tuxdriver.com>
Cc: "Rafał Miłecki" <zajec5@gmail.com>,
	linux-wireless@vger.kernel.org, b43-dev@lists.infradead.org
Subject: Re: [PATCH] ssb: fail registration for unknown SPROM revision
Date: Wed, 17 Nov 2010 18:12:56 +0100	[thread overview]
Message-ID: <1290013976.2513.14.camel@maggie> (raw)
In-Reply-To: <20101116212321.GF10774@tuxdriver.com> (sfid-20101116_162951_428051_09CF3C97)

On Tue, 2010-11-16 at 16:23 -0500, John W. Linville wrote: 
> > -		ssb_printk(KERN_WARNING PFX "Unsupported SPROM"
> > -			   "  revision %d detected. Will extract"
> > -			   " v1\n", out->revision);
> > -		out->revision = 1;
> > -		sprom_extract_r123(out, in);
> > +		ssb_printk(KERN_ERR PFX "Unsupported SPROM revision %d"
> > +			   " detected\n", out->revision);
> > +		return -EINVAL;
> >  	}
> >  
> >  	if (out->boardflags_lo == 0xFFFF)
> 
> I think this is going to make my b43 PCI-E card not work...I'll try
> it and get back to you...

Hm, what version does it report?

-- 
Greetings Michael.


  reply	other threads:[~2010-11-17 17:13 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-03 22:28 [PATCH] ssb: return -ENOMEM on alloc fail (instead of CRC check's result) Rafał Miłecki
2010-11-03 22:28 ` [PATCH] ssb: fail registration for unknown SPROM revision Rafał Miłecki
2010-11-03 22:36   ` Michael Büsch
2010-11-16 21:23   ` John W. Linville
2010-11-17 17:12     ` Michael Büsch [this message]
2010-11-18 16:27       ` John W. Linville
2010-11-18 16:35         ` Michael Büsch
2010-11-18 16:44           ` Rafał Miłecki
2010-11-18 16:47             ` Michael Büsch
2010-11-18 17:02               ` Larry Finger
2010-11-18 17:07                 ` Michael Büsch
2010-11-18 17:29                   ` Larry Finger
2010-11-18 16:26     ` John W. Linville
2010-11-18 16:35       ` Rafał Miłecki
2010-11-03 22:31 ` [PATCH] ssb: return -ENOMEM on alloc fail (instead of CRC check's result) Rafał Miłecki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1290013976.2513.14.camel@maggie \
    --to=mb@bu3sch.de \
    --cc=b43-dev@lists.infradead.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    --cc=zajec5@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).