From: "Michael Büsch" <mb@bu3sch.de>
To: "Rafał Miłecki" <zajec5@gmail.com>
Cc: linux-wireless@vger.kernel.org,
"John W. Linville" <linville@tuxdriver.com>,
b43-dev@lists.infradead.org
Subject: Re: [RFC][PATCH] b43: rfkill: use HI enabled bit for all devices
Date: Wed, 17 Nov 2010 21:29:58 +0100 [thread overview]
Message-ID: <1290025798.2513.74.camel@maggie> (raw)
In-Reply-To: <AANLkTi=ddd9gTmfWgXgn-8SnTh_br_dTnagOFO0xztvh@mail.gmail.com> (sfid-20101117_212336_672388_05898F4E)
On Wed, 2010-11-17 at 21:23 +0100, Rafał Miłecki wrote:
> >> /* Returns TRUE, if the radio is enabled in hardware. */
> >> -bool b43_is_hw_radio_enabled(struct b43_wldev *dev)
> >> +inline bool b43_is_hw_radio_enabled(struct b43_wldev *dev)
> >
> > inline doesn't make sense here.
>
> Err, tip for compiler for optimization? To avoid some JUMPs in generated ASM?
Inline doesn't really work that way. In this case it might generate
an inline version for callers inside of rfkill.c and an
always-out-of-line version for other callers.
If you really want it inline (Which I think isn't really necessary
as this isn't a fastpath), you'll need to make it static inline
and put it into rfkill.h
--
Greetings Michael.
next prev parent reply other threads:[~2010-11-17 20:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-17 19:56 [RFC][PATCH] b43: rfkill: use HI enabled bit for all devices Rafał Miłecki
2010-11-17 20:17 ` Michael Büsch
2010-11-17 20:23 ` Rafał Miłecki
2010-11-17 20:29 ` Michael Büsch [this message]
2010-11-17 21:02 ` Rafał Miłecki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1290025798.2513.74.camel@maggie \
--to=mb@bu3sch.de \
--cc=b43-dev@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).