From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from 80-190-117-144.ip-home.de ([80.190.117.144]:50230 "EHLO bu3sch.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932154Ab0KRQgD (ORCPT ); Thu, 18 Nov 2010 11:36:03 -0500 Subject: Re: [PATCH] ssb: fail registration for unknown SPROM revision From: Michael =?ISO-8859-1?Q?B=FCsch?= To: "John W. Linville" Cc: =?UTF-8?Q?Rafa=C5=82_Mi=C5=82ecki?= , linux-wireless@vger.kernel.org, b43-dev@lists.infradead.org In-Reply-To: <20101118162748.GB2468@tuxdriver.com> (sfid-20101118_173004_541609_FFFFFFFFBFBD5E1E) References: <1288823326-9686-1-git-send-email-zajec5@gmail.com> <1288823326-9686-2-git-send-email-zajec5@gmail.com> <20101116212321.GF10774@tuxdriver.com> <1290013976.2513.14.camel@maggie> <20101118162748.GB2468@tuxdriver.com> (sfid-20101118_173004_541609_FFFFFFFFBFBD5E1E) Content-Type: text/plain; charset="UTF-8" Date: Thu, 18 Nov 2010 17:35:56 +0100 Message-ID: <1290098156.12596.2.camel@maggie> Mime-Version: 1.0 Sender: linux-wireless-owner@vger.kernel.org List-ID: On Thu, 2010-11-18 at 11:27 -0500, John W. Linville wrote: > On Wed, Nov 17, 2010 at 06:12:56PM +0100, Michael Büsch wrote: > > On Tue, 2010-11-16 at 16:23 -0500, John W. Linville wrote: > > > > - ssb_printk(KERN_WARNING PFX "Unsupported SPROM" > > > > - " revision %d detected. Will extract" > > > > - " v1\n", out->revision); > > > > - out->revision = 1; > > > > - sprom_extract_r123(out, in); > > > > + ssb_printk(KERN_ERR PFX "Unsupported SPROM revision %d" > > > > + " detected\n", out->revision); > > > > + return -EINVAL; > > > > } > > > > > > > > if (out->boardflags_lo == 0xFFFF) > > > > > > I think this is going to make my b43 PCI-E card not work...I'll try > > > it and get back to you... > > > > Hm, what version does it report? > [ 1036.293865] ssb: Unsupported SPROM revision 255 detected. Will extract v1 So what about specialcasing 255 instead of defaulting to 1 in general? if (rev == 255) rev = 1; 255 basically means "Vendor forgot to set this field". So it would only default to 1 for those broken sproms. -- Greetings Michael.