From: "Michael Büsch" <mb@bu3sch.de>
To: Larry Finger <Larry.Finger@lwfinger.net>
Cc: "Rafał Miłecki" <zajec5@gmail.com>,
"John W. Linville" <linville@tuxdriver.com>,
linux-wireless@vger.kernel.org, b43-dev@lists.infradead.org
Subject: Re: [PATCH] ssb: fail registration for unknown SPROM revision
Date: Thu, 18 Nov 2010 18:07:55 +0100 [thread overview]
Message-ID: <1290100075.12596.8.camel@maggie> (raw)
In-Reply-To: <4CE55C3B.6020803@lwfinger.net> (sfid-20101118_180314_721728_2D534AE3)
On Thu, 2010-11-18 at 11:02 -0600, Larry Finger wrote:
> On 11/18/2010 10:47 AM, Michael Büsch wrote:
> > If it would really succeed to initialize the device, this would be a
> > regulatory issue, because the sprom contains various power amplifier
> > calibration data. I think it should rather fail and be fixed correctly
> > instead of incorrectly using rev1 in that case.
>
> I agree that it is better to fail than use incorrect power data.
>
> Would it be useful if the SPROM data were logged when the revision is crap?
We need to keep in mind that there will be no new SSB devices.
It seems pretty much EOL'ed by Broadcom.
So I'm not sure whether this would be of any use or just random dead
code.
--
Greetings Michael.
next prev parent reply other threads:[~2010-11-18 17:08 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-03 22:28 [PATCH] ssb: return -ENOMEM on alloc fail (instead of CRC check's result) Rafał Miłecki
2010-11-03 22:28 ` [PATCH] ssb: fail registration for unknown SPROM revision Rafał Miłecki
2010-11-03 22:36 ` Michael Büsch
2010-11-16 21:23 ` John W. Linville
2010-11-17 17:12 ` Michael Büsch
2010-11-18 16:27 ` John W. Linville
2010-11-18 16:35 ` Michael Büsch
2010-11-18 16:44 ` Rafał Miłecki
2010-11-18 16:47 ` Michael Büsch
2010-11-18 17:02 ` Larry Finger
2010-11-18 17:07 ` Michael Büsch [this message]
2010-11-18 17:29 ` Larry Finger
2010-11-18 16:26 ` John W. Linville
2010-11-18 16:35 ` Rafał Miłecki
2010-11-03 22:31 ` [PATCH] ssb: return -ENOMEM on alloc fail (instead of CRC check's result) Rafał Miłecki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1290100075.12596.8.camel@maggie \
--to=mb@bu3sch.de \
--cc=Larry.Finger@lwfinger.net \
--cc=b43-dev@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).