Re: iwlwifi: fix modular legacy build errors

[Johannes Berg <johannes@sipsolutions.net>]

On Thu, 2010-11-18 at 11:29 -0800, Randy Dunlap wrote:

> It's listed as being part of the linux-next pull, so I guess that there is still
> some sort of config/build problem.
> 
> Same linker errors as above.  Here is today's config file that causes the error (attached).
> 
> 
> CONFIG_IWLWIFI=m
> CONFIG_IWLWIFI_DEBUG=y
> # CONFIG_IWLWIFI_DEBUG_EXPERIMENTAL_UCODE is not set
> # CONFIG_IWLAGN is not set
> CONFIG_IWL3945=m

Yeah, it's a bit confusing .. I'm pretty sure I tried all this when
doing the non-5000+ patch. Can you try adding

iwlcore-objs += $(iwlcore-m)

to your Makefile after the iwl-legacy lines and see if that helps for
you as well? It seems that the reason is that iwl-legacy never gets
added because it's -m?

But then why did iwlagn-$(CONFIG_IWL4965) and iwl3945-$(CONFIG_IWL3945)
work for you? That bit confuses me completely. It looks like this should
be working? I mean -- why doesn't iwl-legacy.c now get compiled, but
does if you move it to agn like you did here:


-iwlagn-$(CONFIG_IWL4965) += iwl-4965.o
+iwlagn-$(CONFIG_IWL4965) += iwl-4965.o iwl-legacy.o

Why does that work, but not iwlcore-$(CONFIG_IWL4965)??

johannes