From: Johannes Berg <johannes@sipsolutions.net>
To: Randy Dunlap <randy.dunlap@oracle.com>
Cc: "John W. Linville" <linville@tuxdriver.com>,
"Guy, Wey-Yi" <wey-yi.w.guy@intel.com>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: Re: iwlwifi: fix modular legacy build errors
Date: Thu, 18 Nov 2010 12:03:17 -0800 [thread overview]
Message-ID: <1290110597.3801.10.camel@jlt3.sipsolutions.net> (raw)
In-Reply-To: <4CE5849D.1060705@oracle.com>
On Thu, 2010-11-18 at 11:55 -0800, Randy Dunlap wrote:
> > iwlcore-objs += $(iwlcore-m)
> >
> > to your Makefile after the iwl-legacy lines and see if that helps for
> > you as well? It seems that the reason is that iwl-legacy never gets
>
> Yes, that builds fine.
Ok, thanks. I think I'll just not worry about it and add that then.
> > -iwlagn-$(CONFIG_IWL4965) += iwl-4965.o
> > +iwlagn-$(CONFIG_IWL4965) += iwl-4965.o iwl-legacy.o
> >
> > Why does that work, but not iwlcore-$(CONFIG_IWL4965)??
>
> I dunno, but I only tested my erroneous patch when building as loadable
> modules, not builtin. Testing error on my part.
Actually, I get it -- 4965 cannot be modular. And then I probably never
tested 3945 _only_, but maybe only 4965 _only_ ... oh well. I'll go fix
it.
johannes
next prev parent reply other threads:[~2010-11-18 20:01 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-17 16:36 iwlwifi: fix modular legacy build errors Guy, Wey-Yi
2010-11-17 16:49 ` Johannes Berg
2010-11-17 17:12 ` Randy Dunlap
2010-11-17 17:11 ` Guy, Wey-Yi
2010-11-18 17:11 ` Randy Dunlap
2010-11-18 17:36 ` Guy, Wey-Yi
2010-11-18 17:54 ` John W. Linville
2010-11-18 19:29 ` Randy Dunlap
2010-11-18 19:46 ` Johannes Berg
2010-11-18 19:55 ` Randy Dunlap
2010-11-18 20:03 ` Johannes Berg [this message]
2010-11-17 17:06 ` Please revert "iwlwifi: fix modular legacy build errors" patch Guy, Wey-Yi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1290110597.3801.10.camel@jlt3.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=randy.dunlap@oracle.com \
--cc=wey-yi.w.guy@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).