Linux wireless drivers development
 help / color / mirror / Atom feed
From: Tuomas Katila <ext-tuomas.2.katila@nokia.com>
To: "Oikarinen Juuso (Nokia-MS/Tampere)" <juuso.oikarinen@nokia.com>
Cc: "Coelho Luciano (Nokia-MS/Helsinki)" <Luciano.Coelho@nokia.com>,
	"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH] wl12xx: Fix kernel crash related to hw recovery and interface shutdown
Date: Fri, 19 Nov 2010 08:51:52 +0200	[thread overview]
Message-ID: <1290149512.20720.100.camel@tukatila-desktop> (raw)
In-Reply-To: <1290086342-12015-1-git-send-email-juuso.oikarinen@nokia.com>

On Thu, 2010-11-18 at 14:19 +0100, Oikarinen Juuso (Nokia-MS/Tampere)
wrote:
> From: Juuso Oikarinen <juuso.oikarinen@nokia.com>
> 
> It is possible that the op_remove_interface function  is invoked exactly at
> the same time has hw recovery is started. In this case it is possible for the
> interface to be already removed in the op_remove_interface call, which
> currently leads to a kernel warning and a subsequent kernel crash.
> 
> Fix this by ignoring the op_remove_interface call if the interface is already
> down at that point.
> 
> Signed-off-by: Juuso Oikarinen <juuso.oikarinen@nokia.com>
> ---

Tested-by: Tuomas Katila <ext-tuomas.2.katila@nokia.com>

I couldn't see the crash anymore with this patch.

-Tuomas



  reply	other threads:[~2010-11-19  6:58 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-18 13:19 [PATCH] wl12xx: Fix kernel crash related to hw recovery and interface shutdown juuso.oikarinen
2010-11-19  6:51 ` Tuomas Katila [this message]
2010-11-22 12:52 ` Luciano Coelho
2010-11-23  5:51   ` Juuso Oikarinen
2010-11-23  8:47     ` Luciano Coelho

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1290149512.20720.100.camel@tukatila-desktop \
    --to=ext-tuomas.2.katila@nokia.com \
    --cc=Luciano.Coelho@nokia.com \
    --cc=juuso.oikarinen@nokia.com \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox