From: "Guy, Wey-Yi" <wey-yi.w.guy@intel.com>
To: Joe Perches <joe@perches.com>
Cc: Stefano Brivio <stefano.brivio@polimi.it>,
"Chatre, Reinette" <reinette.chatre@intel.com>,
Intel Linux Wireless <ilw@linux.intel.com>,
"John W. Linville" <linville@tuxdriver.com>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 56/62] iwlwifi: Use static const
Date: Mon, 22 Nov 2010 07:37:03 -0800 [thread overview]
Message-ID: <1290440223.7946.0.camel@wwguy-ubuntu> (raw)
In-Reply-To: <2773a20a26f4e326f0849e8ae8fb4f347d6a6ecb.1290305776.git.joe@perches.com>
Hi Joe,
On Sat, 2010-11-20 at 18:38 -0800, Joe Perches wrote:
> Using static const generally increases object text and decreases data size.
> It also generally decreases overall object size.
>
> text data bss dec hex filename
> 48644 57 12120 60821 ed95 drivers/net/wireless/b43/phy_n.o.new
> 48661 57 12120 60838 eda6 drivers/net/wireless/b43/phy_n.o.old
> 37906 86 7904 45896 b348 drivers/net/wireless/iwlwifi/iwl-agn-lib.o.new
> 37937 86 7904 45927 b367 drivers/net/wireless/iwlwifi/iwl-agn-lib.o.old
> 37781 523 6752 45056 b000 drivers/net/wireless/iwlwifi/iwl-3945.o.new
> 37781 523 6752 45056 b000 drivers/net/wireless/iwlwifi/iwl-3945.o.old
>
> Changed b43_nphy_write_clip_detection to take a const u16 *
>
> Signed-off-by: Joe Perches <joe@perches.com>
> ---
I don't see size difference on 3945, otherwise the patch looks ok to me
Wey
next prev parent reply other threads:[~2010-11-22 15:38 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-21 2:38 [PATCH 00/62] drivers/net: Use static const Joe Perches
2010-11-21 2:38 ` [PATCH 50/62] ar9170: Use const Joe Perches
2010-11-21 2:38 ` [PATCH 51/62] ath5k: Use static const Joe Perches
2010-11-21 2:38 ` [PATCH 52/62] ath9k: " Joe Perches
2010-11-21 2:38 ` [PATCH 53/62] carl9170: " Joe Perches
2010-11-21 2:38 ` [PATCH 54/62] atmel: " Joe Perches
2010-11-21 2:38 ` [PATCH 55/62] b43: " Joe Perches
2010-11-21 2:38 ` [PATCH 56/62] iwlwifi: " Joe Perches
2010-11-22 15:37 ` Guy, Wey-Yi [this message]
2010-11-21 2:38 ` [PATCH 57/62] libertas: " Joe Perches
2010-11-21 2:38 ` [PATCH 58/62] ray_cs: " Joe Perches
2010-11-21 2:39 ` [PATCH 59/62] rndis_wlan: " Joe Perches
2010-11-21 2:39 ` [PATCH 60/62] rt2x00: " Joe Perches
2010-11-21 8:58 ` Gertjan van Wingerde
2010-11-21 2:39 ` [PATCH 61/62] wl12xx: " Joe Perches
2010-11-21 2:39 ` [PATCH 62/62] zd1211rw: Use const Joe Perches
2010-11-21 4:50 ` [PATCH 00/62] drivers/net: Use static const David Miller
2010-11-22 22:10 ` Joe Perches
2010-11-22 22:19 ` David Miller
2010-11-22 22:40 ` Joe Perches
2010-11-23 16:28 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1290440223.7946.0.camel@wwguy-ubuntu \
--to=wey-yi.w.guy@intel.com \
--cc=ilw@linux.intel.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=netdev@vger.kernel.org \
--cc=reinette.chatre@intel.com \
--cc=stefano.brivio@polimi.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).