Linux wireless drivers development
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: "Luis R. Rodriguez" <lrodriguez@atheros.com>
Cc: linux-wireless@vger.kernel.org,
	Matt Smith <matt.smith@atheros.com>,
	Senthil Balasubramanian <senthilkumar@atheros.com>
Subject: Re: [PATCH 2/3] ath9k: avoid aggregation for VO traffic
Date: Tue, 23 Nov 2010 07:00:58 +0100	[thread overview]
Message-ID: <1290492058.3674.0.camel@jlt3.sipsolutions.net> (raw)
In-Reply-To: <1290481367.3070.5.camel@Nokia-N900-51-1>

On Tue, 2010-11-23 at 04:02 +0100, Johannes Berg wrote:
> > -        if (ieee80211_is_data_qos(fc)) {
> > +        if (ieee80211_is_data_qos(fc) &&
> > +               (ieee802_1d_to_ac[skb->priority] != IEEE80211_AC_VO)) {
> 
> Isn't skb queue mapping set up already so you could use that?

It must be set up, so you should use that, compare it to AC_VO, and drop
patch 1.

johannes


  reply	other threads:[~2010-11-23  6:01 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-23  1:23 [PATCH 1/3] mac80211: make ieee802_1d_to_ac avilable to drivers Luis R. Rodriguez
2010-11-23  1:23 ` [PATCH 2/3] ath9k: avoid aggregation for VO traffic Luis R. Rodriguez
2010-11-23  3:02   ` Johannes Berg
2010-11-23  6:00     ` Johannes Berg [this message]
2010-11-23 12:14   ` Björn Smedman
2010-11-23 12:56     ` Felix Fietkau
2010-11-23 13:40       ` Björn Smedman
2010-11-23  1:23 ` [PATCH 3/3] mac80211: " Luis R. Rodriguez
2010-11-23  3:01 ` [PATCH 1/3] mac80211: make ieee802_1d_to_ac avilable to drivers Johannes Berg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1290492058.3674.0.camel@jlt3.sipsolutions.net \
    --to=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    --cc=lrodriguez@atheros.com \
    --cc=matt.smith@atheros.com \
    --cc=senthilkumar@atheros.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox