Re: [PATCH] wl12xx: Remove 11j channels from the supported channels list.

[Luciano Coelho <luciano.coelho@nokia.com>]

On Mon, 2010-11-29 at 13:06 +0100, ext Gábor Stefanik wrote:
> On Mon, Nov 29, 2010 at 11:05 AM,  <juuso.oikarinen@nokia.com> wrote:
> > From: Juuso Oikarinen <juuso.oikarinen@nokia.com>
> >
> > Because we don't support them at this stage.
> >
> > Signed-off-by: Juuso Oikarinen <juuso.oikarinen@nokia.com>
> > ---
> >  drivers/net/wireless/wl12xx/main.c |    8 --------
> >  1 files changed, 0 insertions(+), 8 deletions(-)
> >
> > diff --git a/drivers/net/wireless/wl12xx/main.c b/drivers/net/wireless/wl12xx/main.c
> > index 7fecefe..dc3a093 100644
> > --- a/drivers/net/wireless/wl12xx/main.c
> > +++ b/drivers/net/wireless/wl12xx/main.c
> > @@ -2374,14 +2374,6 @@ static struct ieee80211_rate wl1271_rates_5ghz[] = {
> >
> >  /* 5 GHz band channels for WL1273 */
> >  static struct ieee80211_channel wl1271_channels_5ghz[] = {
> 
> Is this for WL1271 or WL1273? The comment contradicts the name...

The wl1273 chip supports 5GHz channels.  The wl1271 chip doesn't.

The driver supports both wl1271 and wl1273.  We have even changed the
name to align with this (the driver is now called wl12xx).

We changed the file names and the module names already, but we haven't
changed the function and structure names yet.  At some point someone
will s/wl1271/wl12xx/.  Yes, it is confusing as it is right now, so
hopefully the renaming will happen soon.  Volunteers? ;)

-- 
Cheers,
Luca.